feat/CXSPA-7301: Allow Billing Address + Guest checkout - in Digital Payments #18892
Conversation
anjana-bl
changed the title
4 flaky tests on run #44014 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Assisted Service Module > Customer Support Agent - Emulation > should checkout as customer |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #18892 ↗︎
|
Looks good when looking at the changes related to the core project |
| const numbers = getAddressNumbers(address, textPhone, textMobile); | ||
|
|
||
| return { | ||
| textBold: address.firstName + ' ' + address.lastName, |
There was a problem hiding this comment.
Small but better to use template literals:
textBold: ${address.firstName} ${address.lastName}
| address.line1, | ||
| address.line2, | ||
| address.town + ', ' + region + address.country?.isocode, | ||
| address.postalCode, |
There was a problem hiding this comment.
Template literal here too:
${address.town}, ${region}${address.country?.isocode}
| } | ||
|
|
||
| isBillingAddressSameAsDeliveryAddress(): boolean { | ||
| if (this.billingAddress === undefined) { |
There was a problem hiding this comment.
Without using if statements, I think we can rewrite this as:
return this.billingAddress !== undefined;
| this.launchDialogService.closeDialog(reason); | ||
| } | ||
|
|
||
| continue() { |
There was a problem hiding this comment.
I would change to something like continueNavigation(). continue is a reserved word in JS
| clickAddNewPayment(); | ||
| cy.wait('@getDigitalPaymentsRequest'); | ||
| fillBillingAddress(my_user.billingAddress); | ||
| cy.get('button.btn.btn-block.btn-secondary') |
There was a problem hiding this comment.
I assume some of these could be moved to a helper class but it's nothing urgent
| @@ -0,0 +1,211 @@ | |||
| <!-- BILLING --> | |||
There was a problem hiding this comment.
Please make sure to test this feature from a customer perspective:
https://jira.tools.sap/browse/CXSPA-7301
The following is a checklist for new epics or features acceptance for Spartacus, based on our Definition of Done document
General
Audits/reviews
New Library
If your epic will be introduced or introduces a new library:
Sample data
If the new feature requires new or updated sample data for a specific Commerce backend version:
Documentation