-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (CXSPA-1094) - Store finder alerts #18961
base: develop
Are you sure you want to change the base?
Conversation
3 flaky tests on run #44026 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
SSR > should render PDP |
Test Replay
Screenshots
Video
|
Review all test suite changes for PR #18961 ↗︎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me. I think we don't need to worry about making the TODO:
comments and cleanup tickets for the future ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, narration is present in both JAWS and VO.
Ticket: CXSPA-1094
I had a hard time getting the 'aria-live' to cooperate here. I have used the 'role="alert"' instead. This makes it easier to control what has to be read out. @developpeurweb Please let me know if this approach provides appropriate screen reader UX.