Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-999) - Checkout progress aria attributes #18984

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Jun 19, 2024

Ticket: CXSPA-999

I've tested with both JAWS and VO and adding those attributes should provide necessary information.

@Pio-Bar Pio-Bar requested a review from a team as a code owner June 19, 2024 10:49
@github-actions github-actions bot marked this pull request as draft June 19, 2024 10:49
@Pio-Bar Pio-Bar marked this pull request as ready for review June 19, 2024 10:50
Copy link

cypress bot commented Jun 19, 2024

3 flaky tests on run #44086 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 021c129 into 2a25815...
Project: spartacus Commit: ef48db0180 ℹ️
Status: Passed Duration: 04:10 💡
Started: Jun 19, 2024 11:00 AM Ended: Jun 19, 2024 11:04 AM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18984 ↗︎

@github-actions github-actions bot marked this pull request as draft June 25, 2024 21:22
@developpeurweb
Copy link
Contributor

This works well on JAWS (although it doesn't convey a step has been completed) but for some reason, especially between steps on VO, there's no way to tell if the user has completes a step already, or which step is selected. To make status for each state very clear to screen reader users, let's try to include the status as part of the aria-label, as it was done recently for the Results Page pagination.

E.g.

  • aria-label="Shipping Address, completed"
  • aria-label="Delivery Mode, selected"
  • aria-label="Payment, disabled"
confusing steps cxspa-999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants