fix: Different aria-labels for un-/selected values for radio-buttons #19015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 flaky tests on run #44173 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Apparel - checkout as guest > Desktop > should perform checkout as guest, create an account and verify guest data |
Test Replay
Screenshots
Video
|
|
ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #19015 ↗︎
Larisa-Staroverova
previously approved these changes
Jul 2, 2024
Uli-Tiger
requested changes
Jul 2, 2024
Comment on lines
263
to
268
| this.translation | ||
| .translate( | ||
| 'configurator.a11y.selectedValueOfAttributeFullWithPrice', | ||
| { | ||
| value: value.valueDisplay, | ||
| attribute: attribute.label, | ||
| price: value.valuePrice.formattedValue, | ||
| } | ||
| ) | ||
| .translate(translationKey, { | ||
| value: value.valueDisplay, | ||
| attribute: attribute.label, | ||
| price: value.valuePrice.formattedValue, | ||
| }) |
There was a problem hiding this comment.
@steinsebastian can you do me a favor to refactor the method,
- so there is only one call to the translation service.
- that multi level if can be replacded by a simple if - else if - else
psydo code
if(totalprice != 0) {
key = ...
params = ...
} else if (valueprice != 0){
key = ...
params = ...
} else{
key = ...
params = ...
}
transService.translate.....
return
i believe this makes it easier to understand what the method does and that there are exactly 3 paths.
There was a problem hiding this comment.
Uli-Tiger
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.