Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide support for type augmentation #8534

Merged
merged 9 commits into from
Aug 11, 2020
Merged

feat: Provide support for type augmentation #8534

merged 9 commits into from
Aug 11, 2020

Conversation

dunqan
Copy link
Contributor

@dunqan dunqan commented Aug 11, 2020

Allowing for the extensibility of our build-in core models helps in implementing a da- ta-driven approach for both our own libraries and 3rd party ones.

As there are some well-known limitations in TypeScript around it, mentioned in those tickets:

Spartacus uses additional build step for our libraries that will move augmentable models to main entry point generated by ng-packagr (eg spartacus-core.d.ts for core).

Closes #7940

@dunqan dunqan changed the title Provide support for type augmentation feat: Provide support for type augmentation Aug 11, 2020
@github-actions
Copy link
Contributor

Public API change detection bot

@spartacus/assets public API diff

nothing changed ;)

@spartacus/storefront public API diff

nothing changed ;)

@spartacus/cds public API diff

nothing changed ;)

@spartacus/core public API diff

unable to analyze this library :(
Please check changes in public API manually.

@cypress
Copy link

cypress bot commented Aug 11, 2020



Test summary

37 0 0 0


Run details

Project spartacus
Status Passed
Commit 4de4f4f
Started Aug 11, 2020 7:19 AM
Ended Aug 11, 2020 7:23 AM
Duration 03:58 💡
OS Linux Debian - 8.11
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dunqan dunqan merged commit 3a98614 into develop Aug 11, 2020
@dunqan dunqan deleted the feature/GH-7940 branch August 11, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for type augmentation
2 participants