Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 8835 move connectors adapters #8862

Conversation

ChristophHi
Copy link
Contributor

No description provided.

@ChristophHi ChristophHi requested a review from a team September 10, 2020 06:23
@@ -30,8 +33,4 @@ export * from './src/user/index';
export * from './src/util/index';
export * from './src/window/index';

/** AUGMENTABLE_TYPES_START */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind bringing back the grouping of exports under the magic comment?

The order in this file is crucial for augmentable types feature to work (we run special post-builder for the types here under the magic comment) (see #7940). AFAIK it's used only in core public_api.ts for now.

Btw. Thanks! You helped me notice how fragile is the mechanism and we will work on making it more bulletproof.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good hint, thanks..This is due the auto import organize which I should not run here

@github-actions
Copy link
Contributor

Public API change detection bot

@spartacus/assets public API diff

nothing changed ;)

@spartacus/storefront public API diff

 import { Route } from '@angular/router';
 import { Router } from '@angular/router';
-import { RouterState } from '@spartacus/core';
 import { RouterStateSnapshot } from '@angular/router';
 import { RoutingConfig } from '@spartacus/core';
@@
 
 // @public (undocumented)
-export namespace ConfigurationRouter {
-    // (undocumented)
-    export interface Data {
-        // (undocumented)
-        configuratorType?: string;
-        // (undocumented)
-        displayOnly?: boolean;
-        // (undocumented)
-        forceReload?: boolean;
-        // (undocumented)
-        isOwnerCartEntry?: boolean;
-        // (undocumented)
-        owner?: GenericConfigurator.Owner;
-        // (undocumented)
-        pageType?: PageType;
-        // (undocumented)
-        resolveIssues?: boolean;
-    }
-    // (undocumented)
-    export enum PageType {
-        // (undocumented)
-        CONFIGURATION = "configuration",
-        // (undocumented)
-        OVERVIEW = "overview"
-    }
-}
-
-// @public
-export class ConfiguratorRouterExtractorService {
-    constructor(configUtilsService: GenericConfiguratorUtilsService, routingService: RoutingService);
-    // (undocumented)
-    protected configUtilsService: GenericConfiguratorUtilsService;
-    // (undocumented)
-    createOwnerFromRouterState(routerState: RouterState): GenericConfigurator.Owner;
-    // (undocumented)
-    extractRouterData(): Observable<ConfigurationRouter.Data>;
-    protected getConfiguratorTypeFromSemanticRoute(semanticRoute: string): string;
-    // (undocumented)
-    protected readonly ROUTE_FRAGMENT_CONFIGURE = "configure";
-    // (undocumented)
-    protected readonly ROUTE_FRAGMENT_OVERVIEW = "configureOverview";
-    // (undocumented)
-    protected routingService: RoutingService;
-}
-
-// @public (undocumented)
 export class ConfigureCartEntryComponent {
     constructor(genericConfigUtilsService: GenericConfiguratorUtilsService, modalService: ModalService);

@spartacus/cds public API diff

nothing changed ;)

@spartacus/core public API diff

unable to analyze this library :(
Please check changes in public API manually.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@ChristophHi ChristophHi merged commit 656944c into epic/product-configuration Sep 11, 2020
@ChristophHi ChristophHi deleted the feature/GH-8835-move-connectors-adapters branch September 11, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants