Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make native boolean support optional #87

Closed
wants to merge 1 commit into from
Closed

Make native boolean support optional #87

wants to merge 1 commit into from

Conversation

kasium
Copy link
Contributor

@kasium kasium commented Jun 23, 2021

No description provided.

@jarus
Copy link
Member

jarus commented Oct 11, 2023

  • How about having some tests which verify that the dialect supports native and non-native booleans?
  • What is the migration path from non-native boolean towards native boolean values? Do we plan to provide a proper migration guide?

@kasium kasium changed the base branch from master to main October 20, 2023 11:18
kasium
kasium commented Nov 3, 2023
View reviewed changes
.gitignore Show resolved Hide resolved
sqlalchemy_hana/dialect.py Show resolved Hide resolved
@kasium kasium mentioned this pull request Nov 3, 2023
Closed
33 tasks
@jarus jarus marked this pull request as draft November 3, 2023 19:37
@kasium kasium closed this Nov 6, 2023
@kasium
Copy link
Contributor Author

kasium commented Nov 6, 2023

I'll create a new pull request for this

@kasium kasium deleted the native-boolean branch November 6, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kasium @jarus