Added section Use Booleans wisely #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtough
added a commit
that referenced
this pull request
Apr 1, 2021
* Creative commons license it's not code, anyway * Create README.md initial title * Scaffolding (#5) * scaffolding * remove non existing logo * update title * README: additional info for onboarding (#6) * scaffolding #2 (#7) * scaffolding #2 * some first intro content + added VSCode build task * first intro content * Inital diagram Finally got ditaa to work. Plantuml activity diagrams are apparently not supported. Not really convinced yet of the text-based diagrams approach. Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * change font to sans-serif (#9) * introduction, minor changes (#10) * some more notes (#12) * some more notes * some words regarding impact * mention abapgit restrictions/design * update scenarios * add note regarding steampunk * first attempt at best practices Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * small formatting issues (#16) * minor changes (#17) * updates (#23) * update deps * updates * upd * closes #15 * upd * small additions and corrections + some official text on (g)CTS Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * move the static analysis part into the tooling chapter (#25) * move the static analysis part into the tooling chapter * add short abaplint description * show 3 toc levels * updates * upd * small corrections and enhancements on tooling Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * Update README.md (#31) * Update README.md * Update README.md * fix typos Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * add title page logo (#33) * add title page logo * add page numbers * Build timestamp * recommend spellchecker * custom dictionary * add this document section (#32) * add this document section * introduction, sections etc. * remove heading, move related work to new chapter * add related work to index * moved to abstract Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * front page hacks (#34) * update links (#36) * update activity diagram (#35) * update activity diagram * upper case OK * polish scenarios (#37) * should fix #26 , #24 , #14 * needs some more polishing of example for #21 * publish pdf to latest tag (#38) * Update build.yml * Create publish.yml * Update build.yml * Update build.yml * Update publish.yml * dummy, testing (#39) * rename release asset (#40) * mention latest release pdf (#43) * minor changes (#41) * link Gerrit * upd * add todos * upd * minor * upd * update abaplint section * some diagrams * more diagrams * I love diagrams * upd * remove "to" * happy -> happen * Update code_review.adoc (#45) ``todo, wording? remove "qualified" ? Done. `` "gain reputation" -> "developers can actively become more knowledgeable about the codebase" something like that No need to overdo it. Meritocracy is all about reputation. I don't see how anyone could take offence in that. * update url (#46) * related work: add link (#47) * workaround page numbering problem (#52) * adjust headings (#51) * update README.md with automatic build information (#48) * update README.md with automatic build information * Update README.md Co-authored-by: Christoph Pohl <christoph.pohl@sap.com> * abapgit examples (#53) * wip: abapgit examples * abapgit chapter updates * split setup steps in two * scenario updates (#49) * scenario updates * upd * upd * clarify * update deps * minor changes (#54) * name in italics * additional abaplint links * abapGit add note * add link * Move gCTS example to separate section (#56) * fixes from Mike (#58) * README: add "Thanks To" seciton (#57) * check links in build (#59) * check links in build * test * move structure * add link to code review guide in main README.md * prepare latest release links release links should point to SAP/styleguides * use main license * parent license * ignore build and node_modules * Delete LICENSE redundant to ../LICENSE * Update .gitignore moved build and node_modules to top level * README, add AsciiDoc notes * code review improvements * motivation: getting different perspectives * selection: mention central distribution by team leads * add missing space * Automated Review --> Checks * disambiguation of terms VCS, git platforms... Co-authored-by: Lars Hvam <larshp@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #14. Joachim has a point here. While we refer to Boolean method parameters in a separate section, I think it makes sense to detail some different aspects in the Booleans section as well.
Kindly be critical with the examples. Gender was what came to my mind as a recent example and thus an obvious choice, but I know that this topic is sensitive. Maybe somebody can come up with a more neutral, business-document-driven example?