Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable modern preload bundles without dependencies #739

Merged
merged 5 commits into from Apr 27, 2022

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Apr 27, 2022

Follow up of #734, which GitHub didn't update any more after a certain force-push.

Currently, when building a UI5 project without dependencies, the legacy
bundle format is used. This change defaults to the new bundle format and
removes any checks for the existence of core modules from the bundle
Builder.

  • bundle/Builder: Remove checks for existence of core modules and
    replace them with bundleOptions "decorateBootstrapModule" and
    "legacyBundleFormat"
  • generate(Component|Library)Preload: Stop globbing dependency resources

JIRA: CPOUI5FOUNDATION-492

Currently, when building a UI5 project without dependencies, the legacy
bundle format is used. This change defaults to the new bundle format and
removes any checks for the existence of core modules from the bundle
Builder.

* bundle/Builder: Remove checks for existence of core modules and
  replace them with bundleOptions "decorateBootstrapModule" and
  "legacyBundleFormat"
* generate(Component|Library)Preload: Stop globbing dependency resources
As discussed: Always use modern APIs in UI5 Tooling 3.0
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 94.926% when pulling 410e6fb on dep-less-preloads into be03519 on next.

@RandomByte RandomByte merged commit 97cfa6c into next Apr 27, 2022
@RandomByte RandomByte deleted the dep-less-preloads branch April 27, 2022 12:20
This was referenced May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants