-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] depCache bundling mode #951
Conversation
3ee7ab6
to
e3d4615
Compare
Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change provide a `ui5.yaml` schema definition for the following feature: SAP/ui5-builder#951 JIRA: CPOUI5FOUNDATION-744
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The depCache is currently broken when using the AutoSplitter (numberOfParts > 1
).
This can be easily reproduced within openui5-sample-app:
builder:
bundles:
- bundleDefinition:
name: depCache-test-bundle.js
sections:
- filters:
- "sap/ui/demo/todo/"
- "sap/ui/demo/todo/manifest.json"
mode: depCache
bundleOptions:
numberOfParts: 2
The bundle then not only contains the modules from the filters (expected), but also dependencies of those modules (outside of the project), although resolve
should default to false
.
0ecfd7d (Enable auto split for depCache) is the commit which broke that behaviour.
A smaller issue is that the part sizes differ a lot (5kb vs 9kb).
Hi @matz3, Thanks for finding those! Regarding the part sizes, it used to be due to the issue with the filtering above. Cheers |
Adds information about specVersion 3.2 **_Note:_** This change shouldn't be merged before: - SAP/ui5-builder#951 - SAP/ui5-project#673 --------- Co-authored-by: Matthias Oßwald <mat.osswald@sap.com>
JIRA: CPOUI5FOUNDATION-744
Dependency cache information that lists modules and their dependencies of all types: JS, declarative views/fragments.
Only the dependencies of the modules are stored as 'depCache' configuration.