Skip to content

Commit

Permalink
[INTERNAL] Fix missing peerDependency to acorn / Add CI check
Browse files Browse the repository at this point in the history
Due to a bug in npm, acorn-jsx can't find the correct version of acorn.

Downgrading to ava@3.11 solves the issue as only one acorn version (v7) is present.

Also adding an 'npm ls' check to detect such issues before they get merged into master.
  • Loading branch information
matz3 committed Sep 2, 2020
1 parent a34b58c commit 84a6f7b
Show file tree
Hide file tree
Showing 3 changed files with 98 additions and 27 deletions.
3 changes: 3 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ steps:
- script: npm ci
displayName: Install Dependencies

- script: npm ls
displayName: Check for missing / extraneous Dependencies

- script: npm run test-azure
displayName: Run Tests

Expand Down
120 changes: 94 additions & 26 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
"yargs": "^15.4.1"
},
"devDependencies": {
"ava": "^3.12.1",
"ava": "3.11.1",
"chokidar-cli": "^2.1.0",
"coveralls": "^3.1.0",
"cross-env": "^7.0.2",
Expand Down

0 comments on commit 84a6f7b

Please sign in to comment.