Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add build flag "--experimental-css-variables" to enable UI5 builds with CSS Variables #501

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[FEATURE] Add build flag "--experimental-css-variables" to enable UI5 builds with CSS Variables #501

merged 1 commit into from
Apr 5, 2022
+32 −3

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Mar 30, 2022 •
edited

Enables build of CSS variables via experimental CLI flag.
BLI: CPOUI5FOUNDATION-346

@flovogt flovogt requested a review from matz3 March 30, 2022 13:40
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.012% when pulling 968a45b on css-variables-api-next into d1a675b on next.

@flovogt flovogt mentioned this pull request Mar 30, 2022
Closed
@matz3
Copy link
Member

matz3 commented Apr 1, 2022

I'd suggest to adopt the PR / commit title to make clear that the --experimental-css-variables option is added. Right now it might sound like the build is enabled by default.

@flovogt flovogt changed the title [FEATURE] enable build with CSS variables [FEATURE] Add build flag "--experimental-css-variables" to enable UI5 builds with CSS Variables Apr 4, 2022
@flovogt flovogt requested a review from KlattG April 4, 2022 13:42
KlattG
KlattG approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt merged commit 0b099db into next Apr 5, 2022
@flovogt flovogt deleted the css-variables-api-next branch April 5, 2022 12:22
@flovogt flovogt mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte left review comments

@matz3 matz3 matz3 approved these changes

@KlattG KlattG KlattG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flovogt @coveralls @matz3 @RandomByte @KlattG