Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] SNAPSHOT Consumption: Add cache-mode parameter #633

Merged
merged 3 commits into from Jun 5, 2023

Conversation

RandomByte
Copy link
Member

Expose cache-mode API parameter via CLI. See also:
SAP/ui5-project#607

@RandomByte RandomByte requested review from KlattG and a team June 2, 2023 11:56
@coveralls
Copy link

coveralls commented Jun 2, 2023

Coverage Status

coverage: 96.704%. remained the same when pulling 39fbdd3 on add-cache-mode-param into 1155cfc on main.

@d3xter666
Copy link
Contributor

LGTM

KlattG
KlattG previously approved these changes Jun 5, 2023
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/cli/commands/build.js Outdated Show resolved Hide resolved
lib/cli/commands/serve.js Outdated Show resolved Hide resolved
lib/cli/commands/tree.js Outdated Show resolved Hide resolved
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RandomByte and others added 3 commits June 5, 2023 16:20
Expose cache-mode API parameter via CLI. See also:
SAP/ui5-project#607
To be discussed: This does not allow for specifying lowercase values
anymore. E.g. 'force'
Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
@RandomByte RandomByte merged commit 61d0865 into main Jun 5, 2023
16 checks passed
@RandomByte RandomByte deleted the add-cache-mode-param branch June 5, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants