Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow resource migration #407

Merged
merged 3 commits into from
Oct 24, 2022
Merged

[FIX] Allow resource migration #407

merged 3 commits into from
Oct 24, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Oct 19, 2022

Allow the usage of a non compliant resource object when writing

@flovogt flovogt changed the title allow resource migration [FIX] Allow resource migration Oct 19, 2022
Base automatically changed from esm to next October 24, 2022 12:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 86.971% when pulling f976574 on allow-resource-migration into 1060810 on next.

@flovogt flovogt merged commit 1722d71 into next Oct 24, 2022
@flovogt flovogt deleted the allow-resource-migration branch October 24, 2022 14:21
@matz3
Copy link
Member

matz3 commented Oct 25, 2022

What was the scenario where this is relevant?

@flovogt
Copy link
Member Author

flovogt commented Oct 26, 2022

We've adjusted the openui5-sample-app with a custom task and a custom middleware to see if its possible to run a v2 configured middleware in the v3 tooling.
The issue occurs when a custom task is importing a fs/Resource from their dependencies. So its a v2 resource. Now, this resource instance is given to any (e.g. workspace.write) API which we inject into the custom task call. This injected API is v3. With that the v3 API has to handle a v2 artefact.

@RandomByte
Copy link
Member

Related change in earlier v2 development: #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants