[FIX] ResourceTagCollection: Do not validate class of resource #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can lead to issues where a custom task creates resources using a different version of @ui5/fs. These reosurces will fail the instanceof check that was implemented here. Instead of checking for the class, we now validate that the resource has a path. The path is currently the only relevant attribute for ResourceTagCollection and mandatory for Resources. Resolves https://github.com/SAP/ui5-fs/issues/269
tobiasso85
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can lead to issues where a custom task creates resources using a
different version of @ui5/fs. These reosurces will fail the instanceof
check that was implemented here.
Instead of checking for the class, we now validate that the resource has
a path. The path is currently the only relevant attribute for
ResourceTagCollection and mandatory for Resources.
Resolves https://github.com/SAP/ui5-fs/issues/269