Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] AbstractAdapter: GLOB match virtual dir fragments #28

Merged
merged 4 commits into from
Jan 31, 2019
Merged

[FIX] AbstractAdapter: GLOB match virtual dir fragments #28

merged 4 commits into from
Jan 31, 2019

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Jul 17, 2018 •
edited
Loading

Work in progress. Required fix for some cases of SAP/ui5-project#4

@RandomByte RandomByte added the bug Something isn't working label Jul 17, 2018
@coveralls
Copy link

coveralls commented Jul 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 84.595% when pulling 0a7ef70 on glob-match-vir-dir-fragments into 68956fb on master.

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@RandomByte RandomByte added this to Low priority in UI5 Tooling - Bug Triage Oct 18, 2018
@RandomByte RandomByte moved this from Low priority to High priority in UI5 Tooling - Bug Triage Jan 17, 2019
@RandomByte
Copy link
Member Author

This also occurs in the context of shimming modules as they can define a virtual-only directory structure. Currently, these directories do not appear in the servers directory listing.

Reference: https://openui5.slack.com/archives/C0A7QFN6B/p1547648769026200

@RandomByte
[INTERNAL] GLOB: Match virtual dir fragments
34559e9
@RandomByte
[INTERNAL] GLOB: Fix and enhance tests
afbcc3f 
Also remove mtime from resources. Unknown why that got added in the first place
@RandomByte RandomByte requested a review from matz3 January 30, 2019 15:50
@RandomByte RandomByte changed the title [FIX][WIP] AbstractAdapter: GLOB match virtual dir fragments [FIX] AbstractAdapter: GLOB match virtual dir fragments Jan 30, 2019
@RandomByte
Copy link
Member Author

Just tested and confirmed that this resolves #28 (comment)

matz3
matz3 requested changes Jan 31, 2019
View reviewed changes
lib/adapters/Memory.js Outdated Show resolved Hide resolved
test/lib/adapters/Memory.js Outdated Show resolved Hide resolved
@RandomByte RandomByte merged commit c8cc5cd into master Jan 31, 2019
UI5 Tooling - Bug Triage automation moved this from High priority to Closed Jan 31, 2019
@RandomByte RandomByte deleted the glob-match-vir-dir-fragments branch January 31, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
UI5 Tooling - Bug Triage
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RandomByte @coveralls @CLAassistant @matz3