Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] CheckBox for boolean properties #93

Merged
merged 6 commits into from
Mar 17, 2020
Merged

[FEATURE] CheckBox for boolean properties #93

merged 6 commits into from
Mar 17, 2020
+109 −1

Conversation

nnaydenow
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

PetyaMarkovaBogdanova
PetyaMarkovaBogdanova reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align vertically the label and the checkbox, maybe with display: inline-block and vertical-align: middle.

app/scripts/modules/ui/helpers/DataViewHelper.js Show resolved Hide resolved
@SeeSharpSoft SeeSharpSoft mentioned this pull request Mar 11, 2020
Merged
@nnaydenow nnaydenow merged commit 46587c5 into SAP:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova PetyaMarkovaBogdanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nnaydenow @CLAassistant @PetyaMarkovaBogdanova