Skip to content

Commit

Permalink
Merge branch 'master' into fix/issue/707/relax-diagnostic
Browse files Browse the repository at this point in the history
  • Loading branch information
marufrasully committed Apr 22, 2024
2 parents 9175a1c + 49d45ee commit aa8d06a
Show file tree
Hide file tree
Showing 5 changed files with 81 additions and 3 deletions.
6 changes: 6 additions & 0 deletions packages/vscode-ui5-language-assistant-bas-ext/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

## 4.0.60

### Patch Changes

- 5b9fa1f: fix: add manual test case

## 4.0.59

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/vscode-ui5-language-assistant-bas-ext/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext",
"description": "A wrapper module for BAS simple extension around Language Support For SAPUI5",
"license": "Apache-2.0",
"version": "4.0.59",
"version": "4.0.60",
"private": false,
"repository": {
"type": "git",
Expand All @@ -13,7 +13,7 @@
},
"devDependencies": {
"fs-extra": "10.1.0",
"vscode-ui5-language-assistant": "4.0.59"
"vscode-ui5-language-assistant": "4.0.60"
},
"files": [
"*.vsix",
Expand Down
6 changes: 6 additions & 0 deletions packages/vscode-ui5-language-assistant/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

## 4.0.60

### Patch Changes

- 5b9fa1f: fix: add manual test case

## 4.0.59

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode-ui5-language-assistant/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "UI5 Language Assistant",
"private": true,
"description": "Language Support For SAPUI5",
"version": "4.0.59",
"version": "4.0.60",
"publisher": "SAPOSS",
"icon": "resources/ui5-language-assistant.png",
"keywords": [
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
# Navigation

## Associated user stories:

[#702](https://github.com/SAP/ui5-language-assistant/issues/702) Enable navigation to controller files

## Install latest UI5 Language Assistant

[UI5 Language Assistant](https://marketplace.visualstudio.com/items?itemName=SAPOSS.vscode-ui5-language-assistant)

## Instructions on how to use `Go to Definition` and `Peek Definition` feature

### Go to Definition:

The Go To Definition feature helps you to navigate to the file and opens the result in a new tab.

Place cursor somewhere inside value of XML attribute where navigation is supported and

- keyboard: press `F12` (in Visual Studio Code), or `Ctrl` + `F11` (in SAP Business Application Studio)

- mouse: right click and select `Go To Definition`, or.

- keyboard and mouse: `CTRL` + `Click` (Win), `command ⌘` + `Click` (Mac)

### Peek Definition:

The Peek Definition feature lets you preview file without switching away from the code that you're editing.

Place cursor somewhere inside value of XML attribute where navigation is supported and

- keyboard: press `Alt` + `F12` (Win), `Option ⌥ ` + `F12` (Mac), or

- mouse: right click and select `Peek Definition`

## Test project

1. Prepare an UI5 Project
- Your project or
- Clone [ui5-language-assistant](https://github.com/SAP/ui5-language-assistant) repo and open `test-packages/framework/projects/cap`
2. Launch VSCode and open project root folder
3. Install project dependencies using command `npm install`

**Note:** For this manual test, we use `test-packages/framework/projects/cap` project

## Navigate to controller files

1. Open `Main.view.xml` file which is located under `app/manage_travels/webapp/ext/main` folder
2. Place cursor anywhere on `"sap.fe.demo.managetravels.ext.main.Main"`
3. Peek Definition (as described above).
- Observe `Main.controller.js` is peeked
4. Go to Definition (as described above).
- Observe navigation to `Main.controller.js`

**Note:**
This feature is supported for value of following xml attributes

- `controllerName`
- `core:require`
- `template:require`

and it can navigate to local file with following extension.

- `<name>.controller.js`
- `<name>.js`
- `<name>.controller.ts`
- `<name>.ts`

0 comments on commit aa8d06a

Please sign in to comment.