Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax diagnostics for aggregation which have alternative types #682

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Dec 12, 2023

Issue: #678

This PR includes

  • Enhance hover documentation with Alternative types: <type> for aggregation which have altTypes
  • Include Property Binding Info properties also for aggregation which have altTypes of PrimitiveType kind
  • No unjustified diagnostics for aggregation which have altTypes of PrimitiveType kind
  • Unit tests to cover above cases

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 0ec31fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/binding Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Jan 9, 2024

@marufrasully marufrasully merged commit 360deaa into master Jan 10, 2024
9 checks passed
@marufrasully marufrasully deleted the fix/678/tooltip branch January 10, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants