Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use logger instead of console.log #683

Merged
merged 10 commits into from
Jan 5, 2024
Merged

fix: use logger instead of console.log #683

merged 10 commits into from
Jan 5, 2024

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Dec 12, 2023

This PR

  • introduce a logger package for reuse
  • adapt test to use latest patch set of fallback e.g 1.71.61
  • adapt latest patch of UI5 in test project
  • rewrite tests

This PR should stabilize pipeline and git ride of console spam.

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 5b18279

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/semantic-model Patch
@ui5-language-assistant/logic-utils Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-validation Patch
@ui5-language-assistant/xml-views-tooltip Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/test-utils Patch
@ui5-language-assistant/test-framework Patch
@ui5-language-assistant/xml-views-quick-fix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested locally.

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

38.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@MN-public MN-public merged commit a9a2141 into master Jan 5, 2024
8 of 9 checks passed
@MN-public MN-public deleted the fix/log-issue branch January 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants