Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: semantic model for UI5, starting from version 1.121.0 #696

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

marufrasully
Copy link
Contributor

Issue: #694

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 6f276cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@ui5-language-assistant/test-utils Patch
@ui5-language-assistant/semantic-model Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
@ui5-language-assistant/semantic-model-types Patch
@ui5-language-assistant/logic-utils Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/context Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/xml-views-quick-fix Patch
@ui5-language-assistant/xml-views-validation Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-tooltip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marufrasully marufrasully changed the title fix: semantic model for UI5 starting with 1.121.0 version fix: semantic model for UI5, starting from version 1.121.0 Mar 11, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@kranthie-sap
Copy link

Merging using admin priveleges as requested.
@marufrasully : Please exclude test-packages folder from sonar config here - https://github.com/SAP/ui5-language-assistant/blob/master/sonar-project.properties#L5-L6 in a separate PR.

@kranthie-sap kranthie-sap merged commit 7edb021 into master Mar 11, 2024
8 of 9 checks passed
@kranthie-sap kranthie-sap deleted the fix/694/ui5-1.121.1 branch March 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants