[INTERNAL] Specifications: Add more tests (#563)

Co-authored-by: Yavor Ivanov <d3xter666@users.noreply.github.com> Co-authored-by: Florian Vogt <florian.vogt@sap.com>
SAP · Feb 1, 2023 · a0e1e96 · a0e1e96
1 parent f90d17a
commit a0e1e96
Show file tree

Hide file tree

Showing 5 changed files with 96 additions and 0 deletions.
diff --git a/test/lib/specifications/Project.js b/test/lib/specifications/Project.js
@@ -92,6 +92,63 @@ test("getCustomTasks/getCustomMiddleware defaults", async (t) => {
 		"Returned correct default value for custom middleware configuration");
 });
 
+test("getFramework*: Defaults", async (t) => {
+	const customProjectInput = clone(basicProjectInput);
+	const project = await Specification.create(customProjectInput);
+	t.is(project.getFrameworkName(), undefined, "Returned correct framework name");
+	t.is(project.getFrameworkVersion(), undefined, "Returned correct framework version");
+	t.deepEqual(project.getFrameworkDependencies(), [], "Returned correct framework dependencies");
+	t.false(project.isFrameworkProject(), "Is not a framework project");
+});
+
+test("getFramework* configurations", async (t) => {
+	const customProjectInput = clone(basicProjectInput);
+	customProjectInput.configuration.framework = {
+		name: "OpenUI5",
+		version: "1.111.1",
+		libraries: [
+			{name: "lib-1"},
+			{name: "lib-2"},
+		]
+	};
+	customProjectInput.id = "@openui5/" + customProjectInput.id;
+	const project = await Specification.create(customProjectInput);
+	t.is(project.getFrameworkName(), "OpenUI5", "Returned correct framework name");
+	t.is(project.getFrameworkVersion(), "1.111.1", "Returned correct framework version");
+	t.deepEqual(project.getFrameworkDependencies(), [
+		{name: "lib-1"},
+		{name: "lib-2"}
+	], "Returned correct framework dependencies");
+	t.true(project.isFrameworkProject(), "Is a framework project");
+});
+
+test("isFrameworkProject: sapui5", async (t) => {
+	const customProjectInput = clone(basicProjectInput);
+	customProjectInput.id = "@sapui5/" + customProjectInput.id;
+	const project = await Specification.create(customProjectInput);
+	t.true(project.isFrameworkProject(), "Is a framework project");
+});
+
+test("isDeprecated/isSapInternal: Defaults", async (t) => {
+	const customProjectInput = clone(basicProjectInput);
+
+	const project = await Specification.create(customProjectInput);
+	t.false(project.isDeprecated(), "Is not deprecated");
+	t.false(project.isSapInternal(), "Is not SAP-internal");
+	t.false(project.getAllowSapInternal(), "Does not allow SAP-internal");
+});
+
+test("isDeprecated/isSapInternal: True", async (t) => {
+	const customProjectInput = clone(basicProjectInput);
+	customProjectInput.configuration.metadata.deprecated = true;
+	customProjectInput.configuration.metadata.sapInternal = true;
+	customProjectInput.configuration.metadata.allowSapInternal = true;
+	const project = await Specification.create(customProjectInput);
+	t.true(project.isDeprecated(), "Is deprecated");
+	t.true(project.isSapInternal(), "Is SAP-internal");
+	t.true(project.getAllowSapInternal(), "Does allow SAP-internal");
+});
+
 test("getServerSettings", async (t) => {
 	const customProjectInput = clone(basicProjectInput);
 	customProjectInput.configuration.server = {

diff --git a/test/lib/specifications/types/Application.js b/test/lib/specifications/types/Application.js
@@ -34,6 +34,18 @@ test("Correct class", async (t) => {
 	t.true(project instanceof Application, `Is an instance of the Application class`);
 });
 
+test("getNamespace", async (t) => {
+	const project = await Specification.create(basicProjectInput);
+	t.is(project.getNamespace(), "id1",
+		"Returned correct namespace");
+});
+
+test("getSourcePath", async (t) => {
+	const project = await Specification.create(basicProjectInput);
+	t.is(project.getSourcePath(), path.join(applicationAPath, "webapp"),
+		"Returned correct source path");
+});
+
 test("getCachebusterSignatureType: Default", async (t) => {
 	const project = await Specification.create(basicProjectInput);
 	t.is(project.getCachebusterSignatureType(), "time",

diff --git a/test/lib/specifications/types/Library.js b/test/lib/specifications/types/Library.js
@@ -62,6 +62,12 @@ test("getNamespace", async (t) => {
 		"Returned correct namespace");
 });
 
+test("getSourcePath", async (t) => {
+	const project = await (new Library().init(basicProjectInput));
+	t.is(project.getSourcePath(), path.join(libraryDPath, "main", "src"),
+		"Returned correct source path");
+});
+
 test("getPropertiesFileSourceEncoding: Default", async (t) => {
 	const project = await (new Library().init(basicProjectInput));
 	t.is(project.getPropertiesFileSourceEncoding(), "UTF-8",

diff --git a/test/lib/specifications/types/Module.js b/test/lib/specifications/types/Module.js
@@ -45,6 +45,21 @@ test("Correct class", async (t) => {
 });
 
 test("getSourcePath: Throws", async (t) => {
+	const project = await Specification.create(basicProjectInput);
+	const err = t.throws(() => {
+		project.getSourcePath();
+	});
+	t.is(err.message, "Projects of type module have more than one source path",
+		"Threw with expected error message");
+});
+
+test("getNamespace", async (t) => {
+	const project = await Specification.create(basicProjectInput);
+	t.is(project.getNamespace(), null,
+		"Returned no namespace");
+});
+
+test("Access project resources via reader", async (t) => {
 	const project = await Specification.create(basicProjectInput);
 	t.throws(() => {
 		project.getSourcePath();

diff --git a/test/lib/specifications/types/ThemeLibrary.js b/test/lib/specifications/types/ThemeLibrary.js
@@ -47,6 +47,12 @@ test("getSourcePath", async (t) => {
 	t.is(project.getSourcePath(), path.join(themeLibraryEPath, "src"), "Correct source path");
 });
 
+test("getNamespace", async (t) => {
+	const project = await Specification.create(basicProjectInput);
+	t.is(project.getNamespace(), null,
+		"Returned no namespace");
+});
+
 test("Access project resources via reader", async (t) => {
 	const project = await Specification.create(basicProjectInput);
 	const reader = project.getReader();