Skip to content

Commit

Permalink
[FIX] ProjectBuilder: Fix verbose logging for already built projects
Browse files Browse the repository at this point in the history
Function was renamed in TaskRunner but mock was not updated.

Enhanced ui5-builder integration tests to cover this:
SAP/ui5-builder#779
  • Loading branch information
RandomByte committed Aug 10, 2022
1 parent 05c29f5 commit f04ffd2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/build/ProjectBuilder.js
Expand Up @@ -133,7 +133,7 @@ class ProjectBuilder {
const projectName = projectBuildContext.getProject().getName();
let msg;
if (alreadyBuilt.includes(projectName)) {
const buildMetadata = projectBuildContext.getTaskRunner().getFormattedBuildMetadata();
const buildMetadata = projectBuildContext.getTaskRunner().getBuildMetadata();
const ts = new Date(buildMetadata.timestamp).toUTCString();
msg = `*> ${projectName} /// already built at ${ts}`;
} else {
Expand Down
4 changes: 2 additions & 2 deletions test/lib/build/ProjectBuilder.js
Expand Up @@ -235,7 +235,7 @@ test.serial("build: Multiple projects", async (t) => {
const requiresBuildAStub = sinon.stub().returns(true);
const requiresBuildBStub = sinon.stub().returns(false);
const requiresBuildCStub = sinon.stub().returns(true);
const getFormattedBuildMetadataStub = sinon.stub().returns({
const getBuildMetadataStub = sinon.stub().returns({
timestamp: "2022-07-28T12:00:00.000Z",
age: "xx days"
});
Expand All @@ -251,7 +251,7 @@ test.serial("build: Multiple projects", async (t) => {
getTaskRunner: () => {
return {
requiresBuild: requiresBuildBStub,
getFormattedBuildMetadata: getFormattedBuildMetadataStub
getBuildMetadata: getBuildMetadataStub
};
},
getProject: sinon.stub().returns(getMockProject("library", "b"))
Expand Down

0 comments on commit f04ffd2

Please sign in to comment.