fix(MessageBox - TypeScript): adjust `onClose` type · SAP/ui5-webcomponents-react@2c21b2d

Triggered via pull request June 26, 2024 07:54

synchronize #5975

fix/mb-close-type

Status Failure

Total duration 7m 51s

Artifacts –

main.yml

on: pull_request

Matrix: Build

Matrix: test / Cypress

6 errors and 10 warnings

The process '/usr/local/bin/yarn' failed with exit code 2

Build (19): packages/main/src/components/MessageBox/index.tsx#L205

Argument of type 'Ui5CustomEvent<DialogDomRef, PopupBeforeCloseEventDetail>' is not assignable to parameter of type 'UIEvent<Element, UIEvent>'.

Build (19): packages/main/src/components/MessageBox/index.tsx#L210

Property 'dataset' does not exist on type 'EventTarget'.

Process completed with exit code 2.

The job was canceled because "_19" failed.

The operation was canceled.

lint: packages/base/src/Device/index.cy.tsx#L12

React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array

lint: packages/base/src/Device/index.cy.tsx#L32

React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array

lint: packages/charts/src/components/BarChart/BarChart.tsx#L79