Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObjectStatus]:[SF]ObjectStatus style should be align with Fiori guidelines #4934

Closed
hxempty opened this issue Aug 2, 2023 · 4 comments · Fixed by #4935 or #4939
Closed

[ObjectStatus]:[SF]ObjectStatus style should be align with Fiori guidelines #4934

hxempty opened this issue Aug 2, 2023 · 4 comments · Fixed by #4935 or #4939
Labels
bug Something isn't working released

Comments

@hxempty
Copy link

hxempty commented Aug 2, 2023 •
edited
Loading

Describe the bug

This is Fiori Guidelines:https://experience.sap.com/fiori-design-web/object-display-elements/#components
image

This is the UI5 example :https://ui5.sap.com//#/entity/sap.m.ObjectStatus/sample/sap.m.sample.ObjectStatus
image

Now It's like this
image
https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-objectstatus--docs
Maybe the border-radius is incorrect.

UI5 Web Components for React Version

v1.17.3

UI5 Web Components Version

~1.15.0

Browser

Chrome
@hxempty hxempty added the bug Something isn't working label Aug 2, 2023
@Lukas742 Lukas742 mentioned this issue Aug 2, 2023
Merged
@hxempty
Copy link
Author

hxempty commented Aug 3, 2023

Hi @Lukas742, How long will it take to see the new features?,Thanks

@Lukas742 Lukas742 mentioned this issue Aug 3, 2023
Merged
@Lukas742
Copy link
Contributor

Lukas742 commented Aug 3, 2023 •
edited
Loading

Hi @hxempty

PR #4939 will add the correct border-radius and some other style updates.
Please note, that we had to split up the refactoring as the specs are already updated, but some CSS vars we're using aren't, so we need to wait for theming-base-content to update the values of the corresponding CSS vars and then again have to wait for ui5-webcomponents to update their dependencies to the respective versions of theming-base-content.

Please also note, that the design you see on experience.sap is using Quartz Light (Fiori 3) and is also not updated to the latest specs and Sap/Open UI5 also seems to have some deprecated values for e.g. the border-radius implemented.

The changes in PR #4939 should most probably be available tomorrow EOB.

Lukas742 added a commit that referenced this issue Aug 4, 2023
@Lukas742
fix(ObjectStatus): apply latest available specs (#4939)
03835db 
Fixes #4934
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

🎉 This issue has been resolved in version v1.18.0 🎉

The release is available on v1.18.0

Your semantic-release bot 📦🚀

Lukas742 added a commit that referenced this issue Oct 9, 2023
@Lukas742
feat(ObjectStatus): add large prop & update design to latest specs (#…
2de9679 
…4935)

Fixes #4934 
FIxes #5079 
Closes #5035

Need to wait for `theming-base-content` version to be updated.
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This issue has been resolved in version v1.21.0 🎉

The release is available on v1.21.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
ui5-webcomponents-react Roadmap
Status: 🆕 New
Milestone
No milestone
2 participants
@Lukas742 @hxempty