Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverflowPopover: The components OverflowToolbarButton and OverflowToolbarToggleButton are not working properly on scoped UI5 instance #5738

Closed
1 task done
Jianrong-Yu opened this issue Apr 19, 2024 · 1 comment · Fixed by #5739
Labels
bug Something isn't working released SAP Signavio

Comments

@Jianrong-Yu
Copy link
Contributor

Jianrong-Yu commented Apr 19, 2024

Describe the bug

Currently we are using Scoping for our Micro-Frontends solution, we found the component <OverflowToolbarButton> created in the Micro-Frontends application does not working properly in main application.

In our case, the <OverflowPopover> is rendered by the main application and the <OverflowToolbarButton> is rendered by the Micro-Frontends application, when the button is rendered on the popover, the label of the button is missing:

Isolated Example

No response

Reproduction steps

  1. Create Main application, render an <OverflowPopover> component, and enable Webpack Federation as host application
  2. Create Micro-Frontends application, render an <OverflowToolbarButton> and export it
  3. In the Main application, import the button rendered by the Micro-Frontends application
    Actual: The label of the button is missing

Expected Behaviour

Expect: The label of the button is rendered correctly

Screenshots or Videos

image
In this case, the <OverflowPopover> is rendered by the main application but the first button <OverflowToolbarButton> is rendered in MFE application with scoping

UI5 Web Components for React Version

1.24.0

UI5 Web Components Version

1.21.0

Browser

Chrome, Edge

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP Signavio

Declaration

  • I’m not disclosing any internal or sensitive information.

Contribution request

I'd like to contribute my solution for this bug.
The proposal-fix PR #5739 is ready for review.

@Jianrong-Yu Jianrong-Yu added the bug Something isn't working label Apr 19, 2024
Jianrong-Yu added a commit to Jianrong-Yu/ui5-webcomponents-react that referenced this issue Apr 19, 2024
Lukas742 pushed a commit that referenced this issue Apr 29, 2024
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.28.1 🎉

The release is available on v1.28.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released SAP Signavio
Projects
Status: 🆕 New
3 participants