fix(ui5-panel): The expand/collapse button is not in the DOM when fix…

…ed (#1793)
SAP · Jun 15, 2020 · 0b1dc52 · 0b1dc52
1 parent 4359b9a
commit 0b1dc52
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 18 deletions.
diff --git a/packages/main/src/Panel.hbs b/packages/main/src/Panel.hbs
@@ -14,18 +14,18 @@
 		aria-expanded="{{accInfo.ariaExpanded}}"
 		aria-controls="{{accInfo.ariaControls}}"
 	>
-		<div
-			class="ui5-panel-header-button-root"
-		>
-			<ui5-button
-				design="Transparent"
-				class="ui5-panel-header-button {{classes.headerBtn}}"
-				icon="navigation-right-arrow"
-				?non-focusable="{{nonFocusableButton}}"
-				@click="{{_toggleButtonClick}}"
-				._buttonAccInfo="{{accInfo.button}}"
-			></ui5-button>
-		</div>
+		{{#unless fixed}}
+			<div class="ui5-panel-header-button-root">
+				<ui5-button
+					design="Transparent"
+					class="ui5-panel-header-button {{classes.headerBtn}}"
+					icon="navigation-right-arrow"
+					?non-focusable="{{nonFocusableButton}}"
+					@click="{{_toggleButtonClick}}"
+					._buttonAccInfo="{{accInfo.button}}"
+				></ui5-button>
+			</div>
+		{{/unless}}
 
 		{{#if _hasHeader}}
 			<slot name="header"></slot>
@@ -44,4 +44,4 @@
 	<div class="ui5-panel-content" id="{{_id}}-content" tabindex="-1" style="{{styles.content}}">
 		<slot></slot>
 	</div>
-</div>
+</div>
diff --git a/packages/main/src/themes/Panel.css b/packages/main/src/themes/Panel.css
@@ -12,10 +12,6 @@
 	border-bottom: 1px solid var(--sapGroup_TitleBorderColor);
 }
 
-:host([fixed]) .ui5-panel-header-button-root {
-	display: none;
-}
-
 :host([fixed]) .ui5-panel-header {
 	padding-left: 1rem;
 }
@@ -81,4 +77,4 @@
 	flex-shrink: 0;
 	width: var(--_ui5_panel_button_root_width);
 	margin-right: .25rem;
-}
+}