Skip to content

Commit

Permalink
fix(ui5-input): change public method to private (#3224)
Browse files Browse the repository at this point in the history
Change public method to private. Related to #3107

BREAKING CHANGE: the isOpen method that used to return if the value state popover is open or closed has been removed.
  • Loading branch information
ilhan007 committed May 12, 2021
1 parent a8eb730 commit 1166fb4
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions packages/main/src/Input.js
Original file line number Diff line number Diff line change
Expand Up @@ -798,10 +798,9 @@ class Input extends UI5Element {

/**
* Checks if the value state popover is open.
* @returns {boolean} true if the popover is open, false otherwise
* @public
* @returns {boolean} true if the value state popover is open, false otherwise
*/
isOpen() {
isValueStateOpened() {
return !!this._isPopoverOpen;
}

Expand Down Expand Up @@ -1129,7 +1128,7 @@ class Input extends UI5Element {
return {
popoverValueState: {
"ui5-valuestatemessage-root": true,
"ui5-responsive-popover-header": !this.isOpen(),
"ui5-responsive-popover-header": !this.isValueStateOpened(),
"ui5-valuestatemessage--success": this.valueState === ValueState.Success,
"ui5-valuestatemessage--error": this.valueState === ValueState.Error,
"ui5-valuestatemessage--warning": this.valueState === ValueState.Warning,
Expand Down

0 comments on commit 1166fb4

Please sign in to comment.