fix(ui5-input, ui5-combobox): improve samples with value state message (

#8595) * refactor(ui5-input, ui5-combobox): improve samples with value state message fixes: #8581 * fix(ui5-input, ui5-combobox): improve docs fixes: #8581 * fix(ui5-input, ui5-combobox): improve docs fixes: #8581 * Revert "fix(ui5-input, ui5-combobox): improve docs This reverts commit 4e8db98. * fix(ui5-input, ui5-combobox): improve samples with value state message * Update TextArea.ts indents * Update TextArea.ts * Update TextArea.ts
SAP · Apr 2, 2024 · 63de7ee · 63de7ee
1 parent 831fad3
commit 63de7ee
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 5 deletions.
diff --git a/packages/main/src/ComboBox.ts b/packages/main/src/ComboBox.ts
@@ -364,6 +364,7 @@ class ComboBox extends UI5Element {
 
 	/**
 	 * Defines the value state message that will be displayed as pop up under the component.
+	 * The value state message slot should contain only one root element.
 	 *
 	 * **Note:** If not specified, a default text (in the respective language) will be displayed.
 	 *

diff --git a/packages/main/src/Input.ts b/packages/main/src/Input.ts
@@ -544,6 +544,7 @@ class Input extends UI5Element implements SuggestionComponent, IFormElement {
 
 	/**
 	 * Defines the value state message that will be displayed as pop up under the component.
+	 * The value state message slot should contain only one root element.
 	 *
 	 * **Note:** If not specified, a default text (in the respective language) will be displayed.
 	 *

diff --git a/packages/main/src/MultiComboBox.ts b/packages/main/src/MultiComboBox.ts
@@ -423,6 +423,7 @@ class MultiComboBox extends UI5Element {
 
 	/**
 	 * Defines the value state message that will be displayed as pop up under the component.
+	 * The value state message slot should contain only one root element.
 	 *
 	 * **Note:** If not specified, a default text (in the respective language) will be displayed.
 	 *

diff --git a/packages/main/src/TextArea.ts b/packages/main/src/TextArea.ts
@@ -290,7 +290,8 @@ class TextArea extends UI5Element implements IFormElement {
 
 	/**
 	 * Defines the value state message that will be displayed as pop up under the component.
-	 *
+	 * The value state message slot should contain only one root element.
+   	 *
 	 * **Note:** If not specified, a default text (in the respective language) will be displayed.
 	 *
 	 * **Note:** The `valueStateMessage` would be displayed if the component has

diff --git a/packages/main/test/pages/ComboBox.html b/packages/main/test/pages/ComboBox.html
@@ -70,9 +70,6 @@
 			<ui5-cb-item text="Belgium"></ui5-cb-item>
 			<ui5-cb-item text="Bosnia and Herzegovina"></ui5-cb-item>
 			<div slot="valueStateMessage">Custom error value state message with a <a href="#">Link</a>.</div>
-			<div slot="valueStateMessage">Additionl custom error value state message with a <a href="#">Link</a>. Extra
-				long text used as an error message. Extra long text used as an error message - 2. Extra long text used
-				as an error message - 3.</div>
 		</ui5-combobox>
 		<ui5-combobox id="vs-warning-default" class="combobox2auto" value-state="Warning">
 			<ui5-cb-item text="Algeria"></ui5-cb-item>

diff --git a/packages/main/test/pages/Input.html b/packages/main/test/pages/Input.html
@@ -99,7 +99,6 @@ <h3>Input with valueState and Dynamic suggestions</h3>
 		value-state="Error"
 		placeholder="Search for a country ...">
 	<div slot="valueStateMessage">Custom error value state message with a <a href="#">Link</a>.</div>
-	<div slot="valueStateMessage">Additionl custom error value state message with a <a href="#">Link</a>. Extra long text used as an error message. Extra long text used as an error message - 2. Extra long text used as an error message - 3.</div>
 	</ui5-input>
 
 	<h3>Input with long suggestions with valueState and ui5-li</h3>