Skip to content

Commit

Permalink
fix(ui5-combobox): translate accessibleName (#1563)
Browse files Browse the repository at this point in the history
  • Loading branch information
ivoplashkov committed Apr 29, 2020
1 parent 51ac193 commit 6cd3da8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/main/src/ComboBox.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
?pressed="{{_iconPressed}}"
@click="{{_arrowClick}}"
dir="{{dir}}"
accessibleName="{{_accessibleNameText}}"
accessibleName="{{_iconAccessibleNameText}}"
></ui5-icon>
{{/unless}}
</div>
5 changes: 5 additions & 0 deletions packages/main/src/ComboBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
VALUE_STATE_ERROR,
VALUE_STATE_WARNING,
INPUT_SUGGESTIONS_TITLE,
ICON_ACCESSIBLE_NAME,
} from "./generated/i18n/i18n-defaults.js";

// Templates
Expand Down Expand Up @@ -479,6 +480,10 @@ class ComboBox extends UI5Element {
return this.i18nBundle.getText(INPUT_SUGGESTIONS_TITLE);
}

get _iconAccessibleNameText() {
return this.i18nBundle.getText(ICON_ACCESSIBLE_NAME);
}

get inner() {
return isPhone() ? this.responsivePopover.querySelector(".ui5-input-inner-phone") : this.shadowRoot.querySelector("[inner-input]");
}
Expand Down

0 comments on commit 6cd3da8

Please sign in to comment.