Skip to content

Commit

Permalink
refactor(ui5-panel): align toggle button visual design (#794)
Browse files Browse the repository at this point in the history
  • Loading branch information
ilhan007 committed Sep 27, 2019
1 parent 855e069 commit 6d34b50
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 49 deletions.
34 changes: 1 addition & 33 deletions packages/main/src/themes/Panel.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,47 +38,21 @@
}

.ui5-panel-header-button {
cursor: pointer;
color: var(--sapUiContentIconColor);
border: none;
background: none;
min-width: 2rem;
width: 2rem;
height: 2rem;
transition: transform 0.4s ease-out;
border: 1px solid transparent;
}

.ui5-panel-header-button-icon {
pointer-events: none;
color: inherit;
}

.ui5-panel-header-button[focused] {
outline-style: var(--_ui5_panel_header_button_outline_style);
outline-offset: -.25rem;
}

.ui5-panel-header-button:hover {
background: var(--_ui5_panel_header_button_hover_background_color);
border: 1px solid var(--_ui5_panel_header_button_hover_border_color);
color: var(--_ui5_panel_header_button_hover_color);
}

.ui5-panel-header-button[active] {
background: var(--_ui5_panel_header_button_active_background_color);
border: 1px solid var(--_ui5_panel_header_button_active_border_color);
color: var(--_ui5_panel_header_button_active_color);
}

:host(:not([_has-header])) .ui5-panel-header-button {
pointer-events: none;
}

:host(:not([_has-header])) .ui5-panel-header-button:focus {
outline: none;
}

:host(:not([_has-header]):not([fixed])) {
cursor: pointer;
}
Expand Down Expand Up @@ -110,10 +84,4 @@
align-items: center;
width: var(--_ui5_panel_button_root_width);
margin-right: .25rem;
}

/* IE specific CSS */

ui5-panel .ui5-panel-header-button[focused] {
outline: none;
}
}
7 changes: 0 additions & 7 deletions packages/main/src/themes/base/Panel-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,5 @@
--_ui5_panel_focus_border: 1px dotted var(--sapUiContentFocusColor);
--_ui5_panel_header_height: 3rem;
--_ui5_panel_header_title_size: var(--sapMFontHeader4Size);
--_ui5_panel_header_button_outline_style: dashed;
--_ui5_panel_header_button_hover_background_color: white;
--_ui5_panel_header_button_active_background_color: white;
--_ui5_panel_header_button_hover_color: var(--sapUiContentIconColor);
--_ui5_panel_header_button_active_color: var(--sapUiContentIconColor);
--_ui5_panel_header_button_hover_border_color: transparent;
--_ui5_panel_header_button_active_border_color: transparent;
--_ui5_panel_button_root_width: 3rem;
}
2 changes: 0 additions & 2 deletions packages/main/src/themes/sap_belize_hcb/Panel-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@

:root {
--_ui5_panel_focus_border: 0.125rem dotted var(--sapUiContentFocusColor);
--_ui5_panel_header_button_active_background_color: transparent;
--_ui5_panel_header_button_hover_background_color: transparent;
}
7 changes: 0 additions & 7 deletions packages/main/src/themes/sap_fiori_3/Panel-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,5 @@
:root {
--_ui5_panel_header_height: 2.75rem;
--_ui5_panel_header_title_size: var(--sapMFontHeader5Size);
--_ui5_panel_header_button_outline_style: dotted;
--_ui5_panel_header_button_hover_background_color: var(--sapUiButtonLiteHoverBackground);
--_ui5_panel_header_button_active_background_color: var(--sapUiButtonLiteActiveBackground);;
--_ui5_panel_header_button_hover_color: var(--sapUiButtonLiteTextColor);
--_ui5_panel_header_button_active_color: var(--sapUiButtonActiveTextColor);
--_ui5_panel_header_button_hover_border_color: var(--sapUiButtonHoverBorderColor);;
--_ui5_panel_header_button_active_border_color: var(--sapUiButtonLiteActiveBorderColor);;
--_ui5_panel_button_root_width: 2.75rem;
}

0 comments on commit 6d34b50

Please sign in to comment.