feat(ui5-fileuploader): Implementing accessiblity specification (#1585)

SAP · May 12, 2020 · 76943bc · 76943bc
1 parent 2a426dd
commit 76943bc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/packages/main/src/FileUploader.hbs b/packages/main/src/FileUploader.hbs
@@ -10,18 +10,21 @@
 				value-state="{{valueState}}"
 				placeholder="{{placeholder}}"
 				?disabled="{{disabled}}"
+				tabindex="-1"
 			></ui5-input>
 		{{/unless}}
 		<slot></slot>
 	</div>
 	{{#if _keepInputInShadowDOM}}
 		<input
 			type="file"
-			title="upload file"
+			title="{{titleText}}"
 			accept="{{accept}}"
 			?multiple="{{multiple}}"
 			?disabled="{{disabled}}"
 			@change="{{_onChange}}"
+			aria-hidden="true"
+			tabindex="-1"
 		>
 	{{else}}
 		<slot name="formSupport">

diff --git a/packages/main/src/FileUploader.js b/packages/main/src/FileUploader.js
@@ -8,6 +8,7 @@ import {
 } from "@ui5/webcomponents-base/dist/i18nBundle.js";
 import {
 	FILEUPLOAD_BROWSE,
+	FILEUPLOADER_TITLE,
 } from "./generated/i18n/i18n-defaults.js";
 import Input from "./Input.js";
 
@@ -305,6 +306,10 @@ class FileUploader extends UI5Element {
 		return this.i18nBundle.getText(FILEUPLOAD_BROWSE);
 	}
 
+	get titleText() {
+		return this.i18nBundle.getText(FILEUPLOADER_TITLE);
+	}
+
 	get _canUseNativeFormSupport() {
 		return !!this.attachInternals;
 	}

diff --git a/packages/main/src/i18n/messagebundle.properties b/packages/main/src/i18n/messagebundle.properties
@@ -47,6 +47,9 @@ DELETE=Delete
 
 FILEUPLOAD_BROWSE=Browse...
 
+#XACT: File uploader title
+FILEUPLOADER_TITLE=Upload File
+
 GROUP_HEADER_TEXT=Group Header
 
 #XTXT