fix(ui5-dialog, ui5-popover): change header level to H1 (#6293)

SAP · Jan 18, 2023 · a9130e8 · a9130e8
1 parent 9d833ff
commit a9130e8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/packages/main/src/Dialog.hbs b/packages/main/src/Dialog.hbs
@@ -16,7 +16,7 @@
 			{{#if header.length }}
 				<slot name="header"></slot>
 			{{else}}
-				<h2 id="ui5-popup-header-text" class="ui5-popup-header-text">{{headerText}}</h2>
+				<h1 id="ui5-popup-header-text" class="ui5-popup-header-text">{{headerText}}</h1>
 			{{/if}}
 		</header>
 	{{/if}}

diff --git a/packages/main/src/Popover.hbs b/packages/main/src/Popover.hbs
@@ -8,7 +8,7 @@
 			{{#if header.length }}
 				<slot name="header"></slot>
 			{{else}}
-				<h2 class="ui5-popup-header-text">{{headerText}}</h2>
+				<h1 class="ui5-popup-header-text">{{headerText}}</h1>
 			{{/if}}
 		</header>
 	{{/if}}

diff --git a/packages/main/test/pages/Dialog.html b/packages/main/test/pages/Dialog.html
@@ -136,7 +136,7 @@
 	<ui5-dialog id="dialog" accessible-name="Resizable" stretch>
 		<div slot="header">
 			<ui5-button id="header-button">focus stop</ui5-button>
-			<ui5-title id="tt" level="H2">Resizable</ui5-title>
+			<ui5-title id="tt" level="H1">Resizable</ui5-title>
 
 		</div>
 
@@ -191,7 +191,7 @@
 
 
 		<div class="dialog3auto">
-			<ui5-title level="H2">Hello World!</ui5-title>
+			<ui5-title level="H1">Hello World!</ui5-title>
 		</div>
 
 		<ui5-select>
@@ -444,7 +444,7 @@
 	<ui5-label id="label-acc-name-ref">Some label</ui5-label>
 	<ui5-dialog id="dialog-acc-name-ref" accessible-name-ref="label-acc-name-ref" stretch>
 		<div slot="header">
-			<ui5-title level="H2">Header</ui5-title>
+			<ui5-title level="H1">Header</ui5-title>
 		</div>
 		<span>Hello World!</span>
 	</ui5-dialog>
@@ -457,31 +457,31 @@
 		<ui5-button id="btn-error-state">Dialog with Error State</ui5-button>
 		<ui5-dialog id="dialog-error-state" state="Error">
 			<div slot="header">
-				<ui5-title level="H2">Error</ui5-title>
+				<ui5-title level="H1">Error</ui5-title>
 			</div>
 			<span>Hello World!</span>
 		</ui5-dialog>
 
 		<ui5-button id="btn-info-state">Dialog with Information State</ui5-button>
 		<ui5-dialog id="dialog-info-state" state="Information">
 			<div slot="header">
-				<ui5-title level="H2">Information</ui5-title>
+				<ui5-title level="H1">Information</ui5-title>
 			</div>
 			<span>Hello World!</span>
 		</ui5-dialog>
 
 		<ui5-button id="btn-success-state">Dialog with Success State</ui5-button>
 		<ui5-dialog id="dialog-success-state" state="Success">
 			<div slot="header">
-				<ui5-title level="H2">Success</ui5-title>
+				<ui5-title level="H1">Success</ui5-title>
 			</div>
 			<span>Hello World!</span>
 		</ui5-dialog>
 
 		<ui5-button id="btn-warn-state">Dialog with Warning State</ui5-button>
 		<ui5-dialog id="dialog-warn-state" state="Warning">
 			<div slot="header">
-				<ui5-title level="H2">Warning</ui5-title>
+				<ui5-title level="H1">Warning</ui5-title>
 			</div>
 			<span>Hello World!</span>
 		</ui5-dialog>
@@ -490,19 +490,19 @@
 	<ui5-button id="dialogOverDialogBtn">Dialog over a Dialog</ui5-button>
 	<ui5-dialog id="dialogOverDialog1">
 		<div slot="header">
-			<ui5-title level="H2">Header 1</ui5-title>
+			<ui5-title level="H1">Header 1</ui5-title>
 		</div>
 		<ui5-button id="dialogOverDialog1Btn">Open a new Dialog</ui5-button>
 	</ui5-dialog>
 	<ui5-dialog id="dialogOverDialog2">
 		<div slot="header">
-			<ui5-title level="H2">Header 2</ui5-title>
+			<ui5-title level="H1">Header 2</ui5-title>
 		</div>
 		<ui5-button id="dialogOverDialog2Btn">Open a new Dialog</ui5-button>
 	</ui5-dialog>
 	<ui5-dialog id="dialogOverDialog3">
 		<div slot="header">
-			<ui5-title level="H2">Header 3</ui5-title>
+			<ui5-title level="H1">Header 3</ui5-title>
 		</div>
 		<ui5-button id="dialogOverDialog3Btn">Close</ui5-button>
 	</ui5-dialog>