Skip to content

Commit

Permalink
fix(ui5-progress-indicator): hidden value design (#8545)
Browse files Browse the repository at this point in the history
Co-authored-by: PetyaMarkovaBogdanova <petya.markova@sap.com>
  • Loading branch information
PetyaMarkovaBogdanova and PetyaMarkovaBogdanova committed Apr 18, 2024
1 parent 4a48a1a commit bf094d3
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 5 deletions.
6 changes: 6 additions & 0 deletions packages/main/src/themes/ProgressIndicator.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
padding-inline-end: var(--_ui5_progress_indicator_padding_end);
}

:host(:not([hidden])[hide-value]) {
padding-top: var(--_ui5_progress_indicator_padding_novalue);
padding-bottom: var(--_ui5_progress_indicator_padding_novalue);

}

.ui5-progress-indicator-root {
display: flex;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@

--_ui5_progress_indicator_side_points_visibility: none;

--_ui5_progress_indicator_padding_novalue: 0;

--_ui5_progress_indicator_host_height: 1rem;
--_ui5_progress_indicator_host_min_height: 1rem;
--_ui5_progress_indicator_root_border_radius: 0.5rem;
--_ui5_progress_indicator_root_height: 100%;
--_ui5_progress_indicator_root_overflow: hidden;

--_ui5_progress_indicator_bar_height: 100%;
--_ui5_progress_indicator_bar_border_radius: 0.5rem 0 0 0.5rem;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
--_ui5_progress_indicator_side_points_visibility: block;

--_ui5_progress_indicator_padding: 1.25rem 0 0.75rem 0;
--_ui5_progress_indicator_padding_novalue: 0.3125rem;
--_ui5_progress_indicator_padding_end: 1.25rem;

--_ui5_progress_indicator_host_height: unset;
--_ui5_progress_indicator_host_min_height: unset;
--_ui5_progress_indicator_host_box_sizing: border-box;
Expand All @@ -31,7 +32,7 @@

--_ui5_progress_indicator_icon_position: absolute;
--_ui5_progress_indicator_icon_right_position: -1.25rem;

--_ui5_progress_indicator_value_margin: 0 0 0.1875rem 0;
--_ui5_progress_indicator_value_position: absolute;
--_ui5_progress_indicator_value_top_position: -1.3125rem;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
--_ui5_progress_indicator_side_points_visibility: block;

--_ui5_progress_indicator_padding: 1.25rem 0 0.75rem 0;
--_ui5_progress_indicator_padding_novalue: 0.3125rem;
--_ui5_progress_indicator_padding_end: 1.25rem;

--_ui5_progress_indicator_host_height: unset;
--_ui5_progress_indicator_host_min_height: unset;
--_ui5_progress_indicator_host_box_sizing: border-box;
Expand All @@ -31,7 +32,7 @@

--_ui5_progress_indicator_icon_position: absolute;
--_ui5_progress_indicator_icon_right_position: -1.25rem;

--_ui5_progress_indicator_value_margin: 0 0 0.1875rem 0;
--_ui5_progress_indicator_value_position: absolute;
--_ui5_progress_indicator_value_top_position: -1.3125rem;
Expand Down

0 comments on commit bf094d3

Please sign in to comment.