Skip to content

Commit

Permalink
fix(ui5-carousel): Fixed paging indicator numbers in right-to-left (R…
Browse files Browse the repository at this point in the history
…TL) mode (#8543)

fix(ui5-carousel): fix navigation numbers displaying in rtl
  • Loading branch information
TeodorTaushanov committed Mar 27, 2024
1 parent 5449f99 commit c032c0c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/main/src/Carousel.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
></div>
{{/each}}
{{else}}
<div class="ui5-carousel-navigation-text">{{selectedIndexToShow}}&nbsp;{{ofText}}&nbsp;{{pagesCount}}</div>
<div dir="auto" class="ui5-carousel-navigation-text">{{selectedIndexToShow}}&nbsp;{{ofText}}&nbsp;{{pagesCount}}</div>
{{/if}}
{{/unless}}
</div>
Expand Down
1 change: 1 addition & 0 deletions packages/main/test/specs/Carousel.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ describe("Carousel general interaction", () => {
const navigation = await carousel.shadow$(".ui5-carousel-navigation > .ui5-carousel-navigation-text");

assert.ok(await navigation.isExisting(), "Navigation is rendered");
assert.ok(await navigation.getAttribute("dir"), "auto", "text direction is auto");
});

it("Buttons are rendered in the content only when hovering (arrows-placement)", async () => {
Expand Down

0 comments on commit c032c0c

Please sign in to comment.