Skip to content

Commit

Permalink
fix(ui5-panel): prevent border cut on horizon themes (#8400)
Browse files Browse the repository at this point in the history
FIXES: #8369
  • Loading branch information
MapTo0 committed Mar 13, 2024
1 parent 9dc902e commit fc2421f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/main/src/themes/Panel.css
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
border: var(--_ui5_panel_focus_border);
border-radius: var(--_ui5_panel_border_radius);
top: var(--_ui5_panel_focus_offset);
bottom: var(--_ui5_panel_focus_offset);
bottom: var(--_ui5_panel_focus_bottom_offset);
left: var(--_ui5_panel_focus_offset);
right: var(--_ui5_panel_focus_offset);
}
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/themes/base/Panel-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
--_ui5_panel_header_padding_right: 0.5rem;
--_ui5_panel_header_button_wrapper_padding: .25rem;
--_ui5_panel_focus_offset: 1px;
--_ui5_panel_focus_bottom_offset: var(--_ui5_panel_focus_offset);
--_ui5_panel_content_padding: 0.625rem 1rem 1.375rem 1rem;
--_ui5_panel_header_background_color: var(--sapBackgroundColor);
}
Expand Down
3 changes: 2 additions & 1 deletion packages/main/src/themes/sap_horizon/Panel-parameters.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
--_ui5_panel_outline_offset: -0.125rem;
--_ui5_panel_border_radius_expanded: var(--sapElement_BorderCornerRadius) var(--sapElement_BorderCornerRadius) 0 0;
--_ui5_panel_icon_color: var(--sapButton_Lite_TextColor);
--_ui5_panel_focus_offset: -1px;
--_ui5_panel_focus_offset: 0px;
--_ui5_panel_focus_bottom_offset: -1px;
--_ui5_panel_content_padding: 0.625rem 1rem;
--_ui5_panel_header_background_color: var(--sapGroup_TitleBackground);
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
--_ui5_panel_outline_offset: -0.125rem;
--_ui5_panel_border_radius_expanded: var(--sapElement_BorderCornerRadius) var(--sapElement_BorderCornerRadius) 0 0;
--_ui5_panel_icon_color: var(--sapButton_Lite_TextColor);
--_ui5_panel_focus_offset: -1px;
--_ui5_panel_focus_offset: 0px;
--_ui5_panel_focus_bottom_offset: -1px;
--_ui5_panel_content_padding: 0.625rem 1rem;
--_ui5_panel_header_background_color: var(--sapGroup_TitleBackground);
}

0 comments on commit fc2421f

Please sign in to comment.