Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input components - Value State Message #1086

Closed
12 tasks done
MapTo0 opened this issue Dec 19, 2019 · 2 comments · Fixed by #2225 or #2258
Closed
12 tasks done

Input components - Value State Message #1086

MapTo0 opened this issue Dec 19, 2019 · 2 comments · Fixed by #2225 or #2258
Labels
feature request High Prio TOPIC RL
Milestone
1.0.0-rc.9

Comments

@MapTo0
Copy link
Member

MapTo0 commented Dec 19, 2019 •
edited by ilhan007
Loading

Implement Value State message for all input like components

  • ComboBox
  • DatePicker
  • DateRangePicker (inherited from DatePicker)
  • DateTimePicker
  • DurationPicker
  • File Uploader
  • Input
  • MultiComboBox
  • MultiInput (inherited from Input, but has some issues)
  • Select
  • TimePicker
  • TextArea

OpenUI5: https://openui5nightly.hana.ondemand.com/entity/sap.m.ComboBox/sample/sap.m.sample.ComboBoxValueState

image

image
@ilhan007 ilhan007 mentioned this issue Apr 14, 2020
Merged
@ilhan007 ilhan007 reopened this Apr 14, 2020
@vladitasev
Copy link
Contributor

Updated with the latest changes, several more needed.

@ilhan007 ilhan007 mentioned this issue Jun 8, 2020
Closed
@nnaydenow nnaydenow mentioned this issue Aug 3, 2020
Merged
nnaydenow added a commit that referenced this issue Aug 5, 2020
@nnaydenow
feat(ui5-select): Implеment value state message
4133a42 
Now, ValueStateMessages are supported in ui5-select when ValueState is set to "Warning", Error or "Information"

#1086
@ilhan007 ilhan007 mentioned this issue Aug 17, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 17, 2020
@ilhan007
feat(ui5-combobox): implement valueStateMessage slot (#2099)
385bb0b 
Related to: #1086
@ilhan007 ilhan007 mentioned this issue Aug 17, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 18, 2020
@ilhan007
feat(ui5-duration-picker): implement valueStateMessage (#2102)
ed3c393 
Related to: #1086
@ilhan007 ilhan007 changed the title Implement Value State Message Input components - Value State Message Aug 18, 2020
@ilhan007 ilhan007 added this to 0.21.10 (released Jul 29, 2020) in UI5 Web Components - Roadmap Aug 19, 2020
@ilhan007 ilhan007 moved this from 0.21.10 (released Jul 29, 2020) to 0.21.11 (released Aug 10, 2020) in UI5 Web Components - Roadmap Aug 19, 2020
@ilhan007 ilhan007 moved this from 0.21.11 (released Aug 10, 2020) to 1.0.0-rc.9 (planned for Oct, 2020) in UI5 Web Components - Roadmap Aug 19, 2020
@ilhan007 ilhan007 moved this from 0.21.11 (released Aug 10, 2020) to 1.0.0-rc.9 (planned for Oct, 2020) in UI5 Web Components - Roadmap Aug 19, 2020
@ilhan007
Copy link
Member

The following components will planned in TEAM RILA

MultiCombobox
MultiInput

@ilhan007 ilhan007 mentioned this issue Aug 20, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 21, 2020
@ilhan007
feat(ui5-file-uploader): implement custom valueStateMessage (#2131)
023e236 
Introduce support for custom value state message as slot. Note: although the ui5-input is internally used, we can not just forward the slot (as in the DatePicker for example), because it is not the element that is clicked, focused and so on.

Related to #1086
@ilhan007 ilhan007 moved this from 1.0.0-rc.9 (planned for Oct, 2020) to TEAM RILA ISSUES in UI5 Web Components - Roadmap Aug 25, 2020
@ilhan007 ilhan007 pinned this issue Aug 25, 2020
@ilhan007 ilhan007 added this to the 1.0.0-rc.9 milestone Aug 25, 2020
@ilhan007 ilhan007 added this to Team Rila in Planning - Topic Core Sep 4, 2020
@ilhan007 ilhan007 removed this from TEAM RILA ISSUES in UI5 Web Components - Roadmap Sep 4, 2020
@ivoplashkov ivoplashkov mentioned this issue Sep 17, 2020
Merged
ilhan007 pushed a commit that referenced this issue Sep 20, 2020
@ivoplashkov
fix(ui5-multiinput): Improve valueStateMessage in nMore popover (#2225)
a03f2b3 
ValueStateMessage is now shown inside the nMore popover on both desktop and mobile devices.

FIXES: #1086
@ilhan007 ilhan007 reopened this Sep 20, 2020
@ivoplashkov ivoplashkov mentioned this issue Sep 28, 2020
Merged
ilhan007 pushed a commit that referenced this issue Sep 30, 2020
@ivoplashkov
feat(ui5-multi-combobox): Implement valueStateMessage (#2258)
793a29e 
Implement valueStateMessage support for MultiComboBox component.

FIXES: #1086
@ilhan007 ilhan007 unpinned this issue Sep 30, 2020
ilhan007 added a commit that referenced this issue Oct 17, 2020
@ilhan007
feat(ui5-file-uploader): implement custom valueStateMessage (#2131)
7d13037 
Introduce support for custom value state message as slot. Note: although the ui5-input is internally used, we can not just forward the slot (as in the DatePicker for example), because it is not the element that is clicked, focused and so on.

Related to #1086
ilhan007 pushed a commit that referenced this issue Oct 17, 2020
@ivoplashkov @ilhan007
fix(ui5-multiinput): Improve valueStateMessage in nMore popover (#2225)
4e54537 
ValueStateMessage is now shown inside the nMore popover on both desktop and mobile devices.

FIXES: #1086
ilhan007 pushed a commit that referenced this issue Oct 17, 2020
@ivoplashkov @ilhan007
feat(ui5-multi-combobox): Implement valueStateMessage (#2258)
8b3c916 
Implement valueStateMessage support for MultiComboBox component.

FIXES: #1086
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
feat(ui5-combobox): implement valueStateMessage slot (#2099)
43d461f 
Related to: #1086
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
feat(ui5-duration-picker): implement valueStateMessage (#2102)
7e1f1d9 
Related to: #1086
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
feat(ui5-file-uploader): implement custom valueStateMessage (#2131)
0db592f 
Introduce support for custom value state message as slot. Note: although the ui5-input is internally used, we can not just forward the slot (as in the DatePicker for example), because it is not the element that is clicked, focused and so on.

Related to #1086
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@ivoplashkov @ilhan007
fix(ui5-multiinput): Improve valueStateMessage in nMore popover (#2225)
222dfb7 
ValueStateMessage is now shown inside the nMore popover on both desktop and mobile devices.

FIXES: #1086
ilhan007 pushed a commit that referenced this issue Nov 11, 2020
@ivoplashkov @ilhan007
feat(ui5-multi-combobox): Implement valueStateMessage (#2258)
06c44d5 
Implement valueStateMessage support for MultiComboBox component.

FIXES: #1086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request High Prio TOPIC RL
Projects
None yet
Milestone
1.0.0-rc.9
4 participants
@MapTo0 @ilhan007 @vladitasev @ivoplashkov