Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ShellBar 'profile' attribute to accept SAP Icons via sap-icon:// namespace #1099

Closed
tnurmi82 opened this issue Dec 30, 2019 · 0 comments · Fixed by #1222
Closed

Allow ShellBar 'profile' attribute to accept SAP Icons via sap-icon:// namespace #1099

tnurmi82 opened this issue Dec 30, 2019 · 0 comments · Fixed by #1222
Assignees
@fifoosid
Labels
feature request

Comments

@tnurmi82
Copy link

ShellBar's 'profile' (and 'logo') properties/attributes only accept URI.

Often web applications do not have profile pictures for logged-in users.

In our case we we would like to use:
profile=sap-icon://account

Current workaround in our SPA was to convert the 'account' icon to a PNG.
But this workaround comes with difficulties regarding alignment, sizing and blurring.
Our image file looks different than adjacent other icons.
@fifoosid fifoosid self-assigned this Feb 17, 2020
@fifoosid fifoosid mentioned this issue Feb 18, 2020
Merged
@fifoosid fifoosid linked a pull request Feb 18, 2020 that will close this issue
feat(ui5-shellbar): add profile slot #1222
Merged
ilhan007 pushed a commit that referenced this issue Feb 18, 2020
@fifoosid
feat(ui5-shellbar): add profile slot (#1222)
9dab18b 
Introduce profile slot, instead of property profile to give more freedom to users, enabling usage of both images and icons for a profile.
Fixes: #1099

BREAKING CHANGE: profile property is removed in favour of profile slot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui5-shellbar): add profile slot SAP/ui5-webcomponents
3 participants
@ilhan007 @fifoosid @tnurmi82