Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-input): implement valueStateMessage with suggestions #1390

Merged
merged 5 commits into from
Apr 1, 2020
Merged

feat(ui5-input): implement valueStateMessage with suggestions #1390

merged 5 commits into from
Apr 1, 2020

Conversation

ivoplashkov
Copy link
Member

Implement valueStateMessage in case of input with suggestions.

ilhan007
ilhan007 reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, I want to test it a little

ilhan007
ilhan007 requested changes Mar 30, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the height of the value state message be as the height of a suggestion item.
Currently it's not, please just check if it should, because I remember something like that.

ilhan007
ilhan007 previously requested changes Mar 30, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It`s worth having sample in Input.sample.html, I can test it I know the playground set up is not easy : (

@ilhan007 ilhan007 merged commit 39068b3 into SAP:master Apr 1, 2020
@ilhan007
Copy link
Member

Fixes: #1086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivoplashkov @ilhan007