ui5-icon: add information to all icons whether they should mirror in RTL #1831
Assignees
Labels
Comments
ilhan007
added a commit
that referenced
this issue
Jun 22, 2020
Currently all icons are mirrored in RTL, but some of the icons should not be mirrored in RTL. The best example is the "accept" icon (checkmark) which does not make sense when mirrored. Now we keep info as "ltr" field in the SAP-Icons.json, which means an icon should remain as it is in RTL, or in other words it is always LTR. We can call the field differently in the SVGRegistry if we want - suppressMirroring, noMirror. I named it "ltr" everywhere for now. FIXES: #1831
ilhan007
moved this from Top Priorities
to 1.0.0-rc.9 (planned for Oct, 2020)
in UI5 Web Components - Roadmap
ilhan007
removed this from 1.0.0-rc.9 (planned for Oct, 2020)
in UI5 Web Components - Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In our icons metadata (the big JSON) we should add info which icons must be mirrored to RTL and which not. Add a new property, f.e. called
mfrommirror, and only set it to true for some of the icons (to save space). Use it for whichever are fewer, f.e.m: trueorm: false.Then use this property inside
Icon.js/hbsin order to enforce the correct mirror behavior.Create a test section in
Icon.htmlfor thatThe text was updated successfully, but these errors were encountered: