feat(framework): make icons RTL aware #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
ilhan007
changed the title
vladitasev
previously requested changes
Jun 19, 2020
| @@ -14,9 +14,9 @@ const calcKey = (name, collection) => { | |||
| return `${collection}:${name}`; | |||
| }; | |||
|
|
|||
| const registerIcon = (name, { pathData, accData, collection } = {}) => { | |||
| const registerIcon = (name, { pathData, ltr, accData, collection } = {}) => { // eslint-disable-line | |||
There was a problem hiding this comment.
Why is the eslint ignore?
There was a problem hiding this comment.
I am getting these (although I am adding one additional key):
17:29 error Expected a line break after this opening brace object-curly-newline
17:66 error Expected a line break before this closing brace object-curly-newline
vladitasev
previously approved these changes
Jun 19, 2020
vladitasev
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all icons are mirrored in RTL, but some of the icons should not be mirrored in RTL. The best example is the "accept" icon (checkmark) which does not make sense when mirrored. Now we keep info as "ltr" field in the SAP-Icons.json, which means an icon should remain as it is in RTL, or in other words it is always LTR. We can call the field differently in the SVGRegistry if we want - suppressMirroring, noMirror. I named it "ltr" everywhere for now.
FIXES: #1831