Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-input does not scroll when you key arrow down #1847

Closed
codefactor opened this issue Jun 21, 2020 · 0 comments · Fixed by #1848
Closed

ui5-input does not scroll when you key arrow down #1847

codefactor opened this issue Jun 21, 2020 · 0 comments · Fixed by #1848
Assignees

Comments

@codefactor
Copy link
Contributor

Describe the bug
When you press the arrow key to select suggestion in the results, the scroll position does not move. It is necessary to move the scroll because we have an infinite loading results, and we use the scroll position to know that the user wants to see more items.

To reproduce
Steps to reproduce the behavior:

  1. Have a search with many suggestions
  2. use keyboard to navigate down the suggestions, go beyond the bottom of the scroll

Expected behavior
The scroll should move down so that the next suggestion item becomes visible at the bottom.

Affected components (if known)
Input, feature InputSuggestions

Log output / Any errors in the console

{...}
@ilhan007 ilhan007 self-assigned this Jun 22, 2020
ilhan007 added a commit that referenced this issue Jun 22, 2020
The scroll container should be awaited before we use it. Additionally, we use the step constant in the "isIteminView" method to avoid half visible items, because previously the input used to scroll if the item is entirely out of view (60 is the maximum height of a standard list item).

FIXES: #1847
ilhan007 added a commit that referenced this issue Jun 23, 2020
The scroll container should be awaited before we use it. Additionally, we use the step constant in the "isIteminView" method to avoid half visible items, because previously the input used to scroll if the item is entirely out of view (60 is the maximum height of a standard list item).

FIXES: #1847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants