Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-date-picker] space key behaviour #2268

Closed
nnaydenow opened this issue Sep 29, 2020 · 0 comments · Fixed by #2279
Closed

[ui5-date-picker] space key behaviour #2268

nnaydenow opened this issue Sep 29, 2020 · 0 comments · Fixed by #2279
Assignees
@fifoosid
Labels
Medium Prio

Comments

@nnaydenow
Copy link
Contributor

  1. When the focus is in the popover, date selection should be done when the SPACE key is released.

Expected:
Date to be selected on keyup.

  1. When the focus is on month / year button and the space key pressed the default browser behaviour should be prevented.

Expected:
Scroll position to be not changed when the space key is pressed.
@fifoosid fifoosid self-assigned this Sep 30, 2020
@fifoosid fifoosid mentioned this issue Sep 30, 2020
Merged
@ilhan007 ilhan007 mentioned this issue Sep 30, 2020
Merged
ilhan007 added a commit that referenced this issue Oct 1, 2020
@ilhan007
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
9d83806 
This PR complements the following PR #2276
to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment.

FIXES: #2268
ilhan007 added a commit that referenced this issue Oct 17, 2020
@ilhan007
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
fea76b2 
This PR complements the following PR #2276
to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment.

FIXES: #2268
ilhan007 added a commit that referenced this issue Nov 11, 2020
@ilhan007
fix(ui5-date-picker): select date with SPACE on keyup (#2279)
3f285b5 
This PR complements the following PR #2276
to fix everything requested by the referenced issue, more specifically forcing date selection with SPACE to take place on keyup, instead of keydown as at the moment.

FIXES: #2268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
Medium Prio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-date-picker): select date with SPACE on keyup SAP/ui5-webcomponents
3 participants
@ilhan007 @fifoosid @nnaydenow