Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-combobox] valueState message text is not centered #2274

Closed
fifoosid opened this issue Sep 30, 2020 · 0 comments
Closed

[ui5-combobox] valueState message text is not centered #2274

fifoosid opened this issue Sep 30, 2020 · 0 comments
Assignees
@ndeshev
Labels
Medium Prio TOPIC RL
Projects
Maintenance - Topic RL

Comments

@fifoosid
Copy link
Contributor

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/main/pages/ComboBox/
  2. Check out the samples with value-state warning or information
  3. Press the arrow to open the popover
  4. The text of the value state is not centered

Expected behavior
The text should be centered vertically.

Screenshots
image

Affected components (if known)
ui5-combobox
@ilhan007 ilhan007 added this to Team RL in Planning - Topic Core Oct 5, 2020
@ilhan007 ilhan007 removed this from Topic RL in Planning - Topic Core Dec 3, 2020
@ilhan007 ilhan007 added this to Issues in Maintenance - Topic RL via automation Dec 3, 2020
@niyap niyap self-assigned this Dec 10, 2020
@ndeshev ndeshev moved this from Issues to In progress in Maintenance - Topic RL Jan 18, 2021
@niyap niyap removed their assignment Jan 25, 2021
@niyap niyap moved this from In progress to New Issues in Maintenance - Topic RL Jan 25, 2021
@ndeshev ndeshev self-assigned this Jan 26, 2021
@ndeshev ndeshev moved this from New Issues to In progress in Maintenance - Topic RL Jan 26, 2021
ndeshev added a commit to ndeshev/ui5-webcomponents that referenced this issue Jan 26, 2021
@ndeshev
fix(ui5-combobox): center valueState message text
0cea145 
ValueState text is now vertically centered in the ResponsivePopover of
the suggestions.

Issue: SAP#2274
@ndeshev ndeshev mentioned this issue Jan 26, 2021
Merged
@ndeshev ndeshev moved this from In progress to Completed in Maintenance - Topic RL Jan 27, 2021
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Feb 1, 2021
@ndeshev @alexandar-mitsev
fix(ui5-combobox, ui5-multicombobox): center ValueState text (SAP#2733)
b7e3af5 
ValueState text is now vertically centered in the Popover's header.

Fixes: SAP#2274
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
@ndeshev @NHristov-sap
fix(ui5-combobox, ui5-multicombobox): center ValueState text (SAP#2733)
01b748f 
ValueState text is now vertically centered in the Popover's header.

Fixes: SAP#2274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndeshev ndeshev

Labels
Medium Prio TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Maintenance - Topic RL
  
Completed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ndeshev @ilhan007 @fifoosid @niyap