Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-combobox: clicking "X" on mobile doesn't cancel selection #2449

Closed
ilhan007 opened this issue Nov 9, 2020 · 0 comments · Fixed by #2742
Closed

ui5-combobox: clicking "X" on mobile doesn't cancel selection #2449

ilhan007 opened this issue Nov 9, 2020 · 0 comments · Fixed by #2742
Assignees
@Martotko
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Maintenance - Topic RL

Comments

@ilhan007
Copy link
Member

ilhan007 commented Nov 9, 2020

Describe the bug
Clicking the "X" button of the ComboBox on mobile doesn't cancel user action.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/ComboBox/
  2. Use chrome mobile emulator
  3. Open any combobox and select any of the available item
  4. Open the combobox and remove the value from the input
  5. Press the "X" button in the right corner
  6. The combo closes and the value is removed but should have remained the same

Context

  • UI5 Web Components version: master

Affected components (if known) ui5-combobox

Reference
https://openui5nightly.hana.ondemand.com/entity/sap.m.ComboBox/sample/sap.m.sample.ComboBox
@ilhan007 ilhan007 added this to Issues in Maintenance - Topic RL via automation Dec 4, 2020
@ilhan007 ilhan007 added the bug This issue is a bug in the code label Jan 13, 2021
@Martotko Martotko self-assigned this Jan 27, 2021
@Martotko Martotko moved this from New Issues to In progress in Maintenance - Topic RL Jan 28, 2021
@Martotko Martotko mentioned this issue Jan 28, 2021
Merged
Maintenance - Topic RL automation moved this from In progress to Completed Feb 12, 2021
ilhan007 pushed a commit that referenced this issue Feb 12, 2021
@Martotko
fix(ui5-combobox): User action cancelled when clicking "X" on mobile (#…
691c2e4 
…2742)

Fixes: #2449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Martotko Martotko

Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Maintenance - Topic RL
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-combobox): User action cancelled when clicking "X" on mobile Martotko/ui5-webcomponents
2 participants
@ilhan007 @Martotko