Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-bagde does not allow overriding CSS letter-spacing #2451

Closed
rajatmtalwar opened this issue Nov 9, 2020 · 2 comments · Fixed by #2493
Closed

ui5-bagde does not allow overriding CSS letter-spacing #2451

rajatmtalwar opened this issue Nov 9, 2020 · 2 comments · Fixed by #2493

Comments

@rajatmtalwar
Copy link

rajatmtalwar commented Nov 9, 2020

Describe the bug
ui5-badge text is not affected by global styles like
* { line-height:1.5 !important; letter-spacing:0.12em !important; word-spacing:0.16em !Important; }

A similar issue was reported for ui5-button for your reference: #2390

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Badge/
  2. Using devtools, add the following CSS rule to the page:

* { line-height:1.5 !important; letter-spacing:0.12em !important; word-spacing:0.16em !Important; }

  1. Notice that letter-spacing is not applied to the Badge text

Isolated example
Please provide an isolated example if possible, by forking CodeSandbox

Expected behavior
All text should adapt to custom spacing.

Screenshots
image

Affected components
ui5-badge

Organization:
SuccessFactors

Priority:
Medium

@ilhan007
Copy link
Member

ilhan007 commented Nov 9, 2020

Already fixed, will be released with the next release - RC.10

Try the preview:
https://sap.github.io/ui5-webcomponents/master/playground/main/pages/Badge/

@ilhan007 ilhan007 closed this as completed Nov 9, 2020
@ilhan007 ilhan007 self-assigned this Nov 9, 2020
@rajatmtalwar
Copy link
Author

rajatmtalwar commented Nov 18, 2020

We still have a problem with letter-spacing. It has hard-coded value.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants