Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and fix failing DateRangePicker test #2475

Closed
vladitasev opened this issue Nov 13, 2020 · 0 comments · Fixed by #2506
Closed

Investigate and fix failing DateRangePicker test #2475

vladitasev opened this issue Nov 13, 2020 · 0 comments · Fixed by #2506
Assignees
@unazko

Comments

@vladitasev
Copy link
Contributor

vladitasev commented Nov 13, 2020 •
edited
Loading

Test removed by:
#2474

  • Find out what's wrong
  • Modify the test
  • Return it
@unazko unazko mentioned this issue Nov 23, 2020
Merged
ilhan007 pushed a commit that referenced this issue Nov 24, 2020
@unazko
fix(ui5-daterange-picker): all tests are now enabled (#2506)
33442e9 
The ui5-daterange-picker tests are now stable and don't introduce timing issues due to rendering of the component.
The ui5-daterange-picker value in the input field gets updated properly on focus out or "Enter" keyboard key press.
Fixes: #2475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-daterange-picker): all tests are now enabled unazko/ui5-webcomponents
3 participants
@ilhan007 @vladitasev @unazko