Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-select: align to other input controls #2485

Closed
nnaydenow opened this issue Nov 16, 2020 · 1 comment · Fixed by #2587
Closed

ui5-select: align to other input controls #2485

nnaydenow opened this issue Nov 16, 2020 · 1 comment · Fixed by #2587
Labels
High Prio TOPIC P

Comments

@nnaydenow
Copy link
Contributor

Description
Change current implementation of ui5-select to be based on native select element.

Motivation
Currently all input ui5 web components are based on native html element:

  • u5-checkbox
  • ui5-radiobutton
  • ui5-input
  • ui5-file-uploader
  • ui5-date-picker
  • and more…

Alignment to the native element will provide native accessibility behaviour.
@dobrinyonkov dobrinyonkov mentioned this issue Nov 20, 2020
Closed
@ilhan007 ilhan007 added this to Topic P in Planning - Topic Core Nov 20, 2020
@nnaydenow nnaydenow mentioned this issue Nov 25, 2020
Closed
@dobrinyonkov dobrinyonkov mentioned this issue Dec 1, 2020
Closed
@nnaydenow nnaydenow mentioned this issue Dec 16, 2020
Merged
ilhan007 pushed a commit that referenced this issue Jan 4, 2021
@nnaydenow
fix(ui5-select): correct role and screen reader speech out (#2587)
59497ee 
- Role of the ui5-select is changed to combobox which change the speech output near to the default behavior. 
- The issue where role="button" can't be used with aria-required / required attribute is fixed. 
- Overwriting the aria-label speech output with aria-labelledby is fixed.

Fixes: #2485
Fixes: #2339
Fixes: #2142
@nnaydenow
Copy link
Contributor Author

Change is not required when the role of the .ui5-select-root could be changed.

ilhan007 pushed a commit that referenced this issue Jan 13, 2021
@nnaydenow @ilhan007
fix(ui5-select): correct role and screen reader speech out (#2587)
6b21952 
- Role of the ui5-select is changed to combobox which change the speech output near to the default behavior. 
- The issue where role="button" can't be used with aria-required / required attribute is fixed. 
- Overwriting the aria-label speech output with aria-labelledby is fixed.

Fixes: #2485
Fixes: #2339
Fixes: #2142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Prio TOPIC P
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-select): correct role and screen reader speech out
2 participants
@ilhan007 @nnaydenow