Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y issue: Tree item at level 2 is not announced correctly by screen reader. #2553

Closed
lateefsofi opened this issue Dec 8, 2020 · 1 comment · Fixed by #2671
Closed

a11y issue: Tree item at level 2 is not announced correctly by screen reader. #2553

lateefsofi opened this issue Dec 8, 2020 · 1 comment · Fixed by #2671
Assignees

Comments

@lateefsofi
Copy link

Tree item at level 2 is not announced correctly by screen reader.
Consider Basic Tree to understand the issue.
When screen reader user navigates through the tree at level 2 i.e Tree 1.1 as per example , screen reader announces 1 of 3 but actually it should announce 1 of 1, because there is only 1 item under its parent.
Similarly if you navigate to the level 2 under Tree 2, for the first item screen reader announces 2 of 3 which is again incorrect, it should be 1 of 2.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Tree
  2. When screen reader user navigates through the tree at level 2 i.e Tree 1.1 as per example , screen reader announces 1 of 3 but actually it should announce 1 of 1, because there is only 1 item under its parent.
    Similarly if you navigate to the level 2 under Tree 2, for the first item screen reader announces 2 of 3 which is again incorrect, it should be 1 of 2.

Expected behavior
Items should be announced to screen readers correctly.

Screenshots
image

Context

  • UI5 Web Components version: 0.23.6

Affected components (if known) Tree

Organization: (if applicable) SuccessFactors

Priority: (optional) (Low, Medium, High or Very High) High

@NHristov-sap
Copy link
Contributor

Hi,

The issue is reproducible. Sometimes (for level 0) it reads properly, but the problem is when the whole tree is expanded, especially in Tree 2 and its sub-trees (when expanded). There are correct announcements of the Tree nodes, but incorrect announcements for number of items (X of Y). Please check!

Best Regards,
Nikolay Hristov
(GitHub Dispatcher)

@ilhan007 ilhan007 added this to Topic RL in Planning - Topic Core Dec 9, 2020
@ilhan007 ilhan007 moved this from Topic RL to Topic P in Planning - Topic Core Dec 9, 2020
@ilhan007 ilhan007 added the approved This issue is approved label Jan 11, 2021
@nnaydenow nnaydenow self-assigned this Jan 12, 2021
nnaydenow added a commit that referenced this issue Jan 12, 2021
Added new aria-posinset and aria-setsize attributes to each element. Now, screen reader will know the count of the items on the same level and the position of the current active item.

Fixes: #2553
ilhan007 pushed a commit that referenced this issue Jan 13, 2021
Added new aria-posinset and aria-setsize attributes to each element. Now, screen reader will know the count of the items on the same level and the position of the current active item.

Fixes: #2553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants