Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Combo box additional text is not visible #2637

Closed
sunnyyadav100 opened this issue Jan 7, 2021 · 1 comment · Fixed by #2642
Closed

Multi Combo box additional text is not visible #2637

sunnyyadav100 opened this issue Jan 7, 2021 · 1 comment · Fixed by #2642

Comments

@sunnyyadav100
Copy link

sunnyyadav100 commented Jan 7, 2021

Describe the bug
A clear and concise description of what the bug is.

To reproduce
Steps to reproduce the behavior:

  1. add ui5-mcb-item as
  2. Additional text information is not propagated to ui5-li component https://github.com/SAP/ui5-webcomponents/blob/master/packages/main/src/MultiComboBoxPopover.hbs#L70

Isolated example

Expected behavior
A clear and concise description of what you expected to happen.

The additional text should be displayed

Screenshots

Context

  • UI5 Web Components version: 1.0.0-rc.11
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}

Affected components (if known)
Multi Combox box

Log output / Any errors in the console

{...}

Organization: (if applicable)
SAP Ariba

Priority: (optional) (Low, Medium, High or Very High)
Medium

@ilhan007 ilhan007 self-assigned this Jan 8, 2021
@ilhan007 ilhan007 added this to Topic RL in Planning - Topic Core Jan 8, 2021
ilhan007 added a commit that referenced this issue Jan 11, 2021
Enables two-column layout items in the MultiComboBox. The MultiComboBoxItem already inherits the additionalText property from the ComboBoxItem, but never used it. The property is visible in the API reference and misleading users that can have two-column layout in the MultiComboBox as well. The change just uses the property in the template and forwards it to the physically rendered list item.

FIXES: #2637
@ilhan007
Copy link
Member

Hello @sunnyyadav100

The additionalText would be displayed properly once the fix is released with RC 12 at the end of January

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants